From: Ensar Sarajčić <dev@ensarsarajcic.com>
Date: Wed, 5 Feb 2025 17:30:30 +0000 (+0100)
Subject: Prevent erasing invalid value from options map
X-Git-Tag: dnsdist-2.0.0-alpha1~111^2~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f36ee29726589ea9d31643a718668c076e0f50a6;p=thirdparty%2Fpdns.git

Prevent erasing invalid value from options map
---

diff --git a/pdns/dnsdistdist/dnsdist-lua-bindings-protobuf.cc b/pdns/dnsdistdist/dnsdist-lua-bindings-protobuf.cc
index 31fa8d1a0a..49f99ec366 100644
--- a/pdns/dnsdistdist/dnsdist-lua-bindings-protobuf.cc
+++ b/pdns/dnsdistdist/dnsdist-lua-bindings-protobuf.cc
@@ -149,7 +149,9 @@ void setupLuaBindingsProtoBuf(LuaContext& luaCtx, bool client, bool configCheck)
     checkAllParametersConsumed("newFrameStreamUnixLogger", params);
     auto connectionCount = options.find("connectionCount");
     auto count = connectionCount == options.end() ? 1 : connectionCount->second;
-    options.erase(connectionCount);
+    if (connectionCount != options.end()) {
+      options.erase(connectionCount);
+    }
     if (count > 1) {
       std::vector<std::shared_ptr<RemoteLoggerInterface>> loggers;
       loggers.reserve(count);
@@ -176,7 +178,9 @@ void setupLuaBindingsProtoBuf(LuaContext& luaCtx, bool client, bool configCheck)
     checkAllParametersConsumed("newFrameStreamTcpLogger", params);
     auto connectionCount = options.find("connectionCount");
     auto count = connectionCount == options.end() ? 1 : connectionCount->second;
-    options.erase(connectionCount);
+    if (connectionCount != options.end()) {
+      options.erase(connectionCount);
+    }
     if (count > 1) {
       std::vector<std::shared_ptr<RemoteLoggerInterface>> loggers;
       loggers.reserve(count);