From: John Ferlan <jferlan@redhat.com>
Date: Sat, 22 Jul 2017 11:05:55 +0000 (-0400)
Subject: storage: Fix editing mistake in storagePoolSetAutostart
X-Git-Tag: v3.6.0-rc1~78
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f36f2e463f877292ee1f30dcb1000337739c2fd3;p=thirdparty%2Flibvirt.git

storage: Fix editing mistake in storagePoolSetAutostart

Commit id '905f1024b' had a rogue editing mistake that inadvertently
dropped a goto cleanup in storagePoolSetAutostart, but Coverity noted it.
---

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index df563f1bda..e616ae0561 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -1280,6 +1280,7 @@ storagePoolSetAutostart(virStoragePoolPtr pool,
     if (!obj->configFile) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        "%s", _("pool has no config file"));
+        goto cleanup;
     }
 
     autostart = (autostart != 0);