From: Volker Lendecke <vl@samba.org>
Date: Wed, 19 Jun 2019 14:08:49 +0000 (+0200)
Subject: smbd: Add a clarifying comment on triggering waiters
X-Git-Tag: ldb-2.0.5~312
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f37c14dd63285e108a9fc1050de9b14a288097cb;p=thirdparty%2Fsamba.git

smbd: Add a clarifying comment on triggering waiters

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/locking/locking.c b/source3/locking/locking.c
index 41b848a3f24..4c059736ae1 100644
--- a/source3/locking/locking.c
+++ b/source3/locking/locking.c
@@ -432,6 +432,12 @@ void locking_close_file(struct messaging_context *msg_ctx,
 	br_lck = brl_get_locks(talloc_tos(),fsp);
 
 	if (br_lck) {
+		/*
+		 * Unlocks must trigger dbwrap_watch watchers,
+		 * normally in smbd_do_unlocking. Here it's done
+		 * implictly, we're closing the file and thus remove a
+		 * share mode. This will wake the waiters.
+		 */
 		brl_close_fnum(msg_ctx, br_lck);
 		TALLOC_FREE(br_lck);
 	}