From: Aurelien DARRAGON <adarragon@haproxy.com>
Date: Fri, 10 Jan 2025 22:56:34 +0000 (+0100)
Subject: MINOR: stktable: fix potential build issue in smp_to_stkey
X-Git-Tag: v3.2-dev4~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f399dbf;p=thirdparty%2Fhaproxy.git

MINOR: stktable: fix potential build issue in smp_to_stkey

smp_to_stkey() uses an ambiguous cast from 64bit integer to 32 bit
unsigned integer. While it is intended, let's make the cast less
ambiguous by explicitly casting the right part of the assignment to the
proper type.

This should fix GH #2838
---

diff --git a/src/stick_table.c b/src/stick_table.c
index eebf3354dd..122870059e 100644
--- a/src/stick_table.c
+++ b/src/stick_table.c
@@ -1500,7 +1500,7 @@ struct stktable_key *smp_to_stkey(struct sample *smp, struct stktable *t)
 		/* The stick table require a 32bit unsigned int, "sint" is a
 		 * signed 64 it, so we can convert it inplace.
 		 */
-		*_sint = smp->data.u.sint;
+		*_sint = (uint)smp->data.u.sint;
 		static_table_key.key = _sint;
 		static_table_key.key_len = 4;
 		break;