From: Jonas Jelonek Date: Sun, 21 Jun 2026 14:41:06 +0000 (+0000) Subject: realtek: pcs: rename 'determine_hw_mode' to 'select_hw_mode' X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f3b7cfcb5839ce00fcfb26fb08379f08ce7217f4;p=thirdparty%2Fopenwrt.git realtek: pcs: rename 'determine_hw_mode' to 'select_hw_mode' Rename the 'determine_hw_mode' to 'select_hw_mode' to better express what the function does. Based on the requested interface, the number of links on a SerDes and the capabilities, it selects a suitable hardware mode. 'determine' is clunkier and less expressive in this case. Link: https://github.com/openwrt/openwrt/pull/23904 Signed-off-by: Jonas Jelonek --- diff --git a/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c b/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c index 627abb65ab1..0cab0af37d1 100644 --- a/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c +++ b/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c @@ -450,9 +450,8 @@ static struct rtpcs_link *rtpcs_phylink_pcs_to_link(struct phylink_pcs *pcs) return container_of(pcs, struct rtpcs_link, pcs); } -static int rtpcs_sds_determine_hw_mode(struct rtpcs_serdes *sds, - phy_interface_t if_mode, - enum rtpcs_sds_mode *hw_mode) +static int rtpcs_sds_select_hw_mode(struct rtpcs_serdes *sds, phy_interface_t if_mode, + enum rtpcs_sds_mode *hw_mode) { u8 n_links = sds->num_of_links; @@ -4032,7 +4031,7 @@ static int rtpcs_pcs_config(struct phylink_pcs *pcs, unsigned int neg_mode, enum rtpcs_sds_mode hw_mode; int ret; - ret = rtpcs_sds_determine_hw_mode(sds, interface, &hw_mode); + ret = rtpcs_sds_select_hw_mode(sds, interface, &hw_mode); if (ret < 0) { dev_err(ctrl->dev, "SerDes %u doesn't support %s mode\n", sds->id, phy_modes(interface));