From: Jiri Denemark <jdenemar@redhat.com>
Date: Thu, 17 Feb 2022 08:36:48 +0000 (+0100)
Subject: qemu: Fix crash at the end of migration
X-Git-Tag: v8.1.0-rc1~39
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f3c2b321e0807399551fa96fa2cae0b12e41fdf4;p=thirdparty%2Flibvirt.git

qemu: Fix crash at the end of migration

The destination daemon would crash in Finish phase due to NULL
dereference which I missed in my review of commit
v8.0.0-428-g0301db44e2

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index fea5e71f4d..5aecdddff0 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -5855,7 +5855,7 @@ qemuMigrationDstFinish(virQEMUDriver *driver,
         if (jobData) {
             priv->job.completed = g_steal_pointer(&jobData);
             priv->job.completed->status = VIR_DOMAIN_JOB_STATUS_COMPLETED;
-            qemuDomainJobSetStatsType(jobData,
+            qemuDomainJobSetStatsType(priv->job.completed,
                                       QEMU_DOMAIN_JOB_STATS_TYPE_MIGRATION);
         }