From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Wed, 26 Jun 2024 17:46:59 +0000 (-0700)
Subject: Fix: use temp dir for split / merge (#7105)
X-Git-Tag: v2.11.0~1^2~38
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f3cf608caafaf6e19e17384748434a422a9522f0;p=thirdparty%2Fpaperless-ngx.git

Fix: use temp dir for split / merge (#7105)
---

diff --git a/src/documents/bulk_edit.py b/src/documents/bulk_edit.py
index 7733a8d68e..7f56a12079 100644
--- a/src/documents/bulk_edit.py
+++ b/src/documents/bulk_edit.py
@@ -2,6 +2,7 @@ import hashlib
 import itertools
 import logging
 import os
+import tempfile
 from typing import Optional
 
 from celery import chain
@@ -269,7 +270,7 @@ def merge(
         return "OK"
 
     filepath = os.path.join(
-        settings.SCRATCH_DIR,
+        tempfile.mkdtemp(dir=settings.SCRATCH_DIR),
         f"{'_'.join([str(doc_id) for doc_id in doc_ids])[:100]}_merged.pdf",
     )
     merged_pdf.remove_unreferenced_resources()
@@ -321,7 +322,7 @@ def split(doc_ids: list[int], pages: list[list[int]], delete_originals: bool = F
                 for page in split_doc:
                     dst.pages.append(pdf.pages[page - 1])
                 filepath = os.path.join(
-                    settings.SCRATCH_DIR,
+                    tempfile.mkdtemp(dir=settings.SCRATCH_DIR),
                     f"{doc.id}_{split_doc[0]}-{split_doc[-1]}.pdf",
                 )
                 dst.remove_unreferenced_resources()