From: Olle Johansson <oej@edvina.net>
Date: Mon, 30 Jan 2006 19:09:08 +0000 (+0000)
Subject: Issue #6035 - Don't send 403 on bad auth (correcting one of my old mistakes...) Repor... 
X-Git-Tag: 1.4.0-beta1~2755
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f3f9230738d2fd843cd86d4c2070831f0f8932db;p=thirdparty%2Fasterisk.git

Issue #6035 - Don't send 403 on bad auth (correcting one of my old mistakes...) Reported by maik.
Patch inspired by, but not the patch in the bug tracker.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8925 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 4aade99dc1..c8fa9b300b 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -6368,9 +6368,14 @@ static int check_auth(struct sip_pvt *p, struct sip_request *req, const char *us
 		} 
 		if (good_response) /* Auth is OK */
 			return 0;
+
+		/* Ok, we have a bad username/secret pair */
+		/* Challenge again, and again, and again */
+		transmit_response_with_auth(p, response, req, p->randdata, reliable, respheader, 0);
+		sip_scheddestroy(p, 32000);
+		return 1;		/* Challenge sent */
+
 	}
-	/* Failure */
-	return -1;
 }
 
 /*! \brief Callback for the devicestate notification (SUBSCRIBE) support subsystem