From: Martin Schwenke <martin@meltin.net>
Date: Fri, 28 Jun 2019 05:44:59 +0000 (+1000)
Subject: ctdb-tools: Drop no-op stdout-filter from non-parallel case
X-Git-Tag: samba-4.11.0rc1~67
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f3feb4df3a90bd40998fa60887a56961954f6423;p=thirdparty%2Fsamba.git

ctdb-tools: Drop no-op stdout-filter from non-parallel case

This filter no longer does anything useful in this context.  By
default it adds a pipeline with trailing cat process.  In many
contexts, stdout of the process being run is still open so the cat
process will stay around and will stop onnode from exiting.

The filters should all go away because they are simply an example of
code that is trying to be too clever while causing unfortunate corner
cases.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
---

diff --git a/ctdb/tools/onnode b/ctdb/tools/onnode
index 76cd2217a0d..863b8b393c5 100755
--- a/ctdb/tools/onnode
+++ b/ctdb/tools/onnode
@@ -352,7 +352,7 @@ for n in $nodes ; do
 			echo >&2 ; echo ">> NODE: $n <<" >&2
 		fi
 		{
-			$ssh_cmd "$n" "$command" | stdout_filter
+			$ssh_cmd "$n" "$command"
 		} || retcode=$?
 	fi
 done