From: Victor Julien <vjulien@oisf.net>
Date: Wed, 25 Jan 2023 10:58:11 +0000 (+0100)
Subject: streaming: remove dead code
X-Git-Tag: suricata-7.0.0-rc1~71
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f41646a012400d8afe049ceee6139f224422fb76;p=thirdparty%2Fsuricata.git

streaming: remove dead code

As reported by Coverity Scan.
---

diff --git a/src/util-streaming-buffer.c b/src/util-streaming-buffer.c
index c1cc515028..b704a62ef9 100644
--- a/src/util-streaming-buffer.c
+++ b/src/util-streaming-buffer.c
@@ -1063,10 +1063,7 @@ static StreamingBufferRegion *FindLargestRegionForOffset(const StreamingBuffer *
         if (!RegionsIntersect(sb, cfg, r, offset, data_re))
             return candidate;
 
-        if (candidate == NULL) {
-            candidate = r;
-            SCLogDebug("candidate %p", candidate);
-        } else if (r->buf_size > candidate->buf_size) {
+        if (r->buf_size > candidate->buf_size) {
             SCLogDebug("candidate %p as size %u > %u", candidate, r->buf_size, candidate->buf_size);
             candidate = r;
         }