From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 19 Nov 2023 12:56:50 +0000 (-0500)
Subject: we don't care about the results of dhcpv4_decode
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f41b20f9f69018e98152df3233174bd8cb9f7b4c;p=thirdparty%2Ffreeradius-server.git

we don't care about the results of dhcpv4_decode

and print the correct pair list we just decoded :(
---

diff --git a/src/bin/dhcpclient.c b/src/bin/dhcpclient.c
index a7c5c43f70f..f568c11a61f 100644
--- a/src/bin/dhcpclient.c
+++ b/src/bin/dhcpclient.c
@@ -709,13 +709,14 @@ int main(int argc, char **argv)
 	}
 
 	/*
-	 *	Decode to produce fr_pair_ts from the default field
+	 *	Decode the request to produce fr_pair_t's from the headers.
 	 */
 	if (fr_debug_lvl) {
 		if (fr_debug_lvl > 1) fr_dhcpv4_print_hex(stdout, packet->data, packet->data_len);
 
-		fr_dhcpv4_decode(packet, &reply_vps, packet->data, packet->data_len, &packet->code);
-		dhcp_packet_debug(packet, &packet_vps, false);
+		(void) fr_dhcpv4_decode(packet, &reply_vps, packet->data, packet->data_len, &packet->code);
+		dhcp_packet_debug(packet, &reply_vps, false);
+		fr_pair_list_free(&reply_vps);
 	}
 
 #ifdef HAVE_LIBPCAP