From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 21 Jan 2019 18:44:01 +0000 (+0100)
Subject: resolved: add comment to dns_stream_complete() about its 'error' argument
X-Git-Tag: v242-rc1~276^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f447d9e3765f33a0bae8abca0e7b673b8e429dd8;p=thirdparty%2Fsystemd.git

resolved: add comment to dns_stream_complete() about its 'error' argument
---

diff --git a/src/resolve/resolved-dns-stream.c b/src/resolve/resolved-dns-stream.c
index 45b06eb732e..3fd056bdb70 100644
--- a/src/resolve/resolved-dns-stream.c
+++ b/src/resolve/resolved-dns-stream.c
@@ -52,6 +52,10 @@ static int dns_stream_complete(DnsStream *s, int error) {
         _cleanup_(dns_stream_unrefp) _unused_ DnsStream *ref = dns_stream_ref(s); /* Protect stream while we process it */
 
         assert(s);
+        assert(error >= 0);
+
+        /* Error is > 0 when the connection failed for some reason in the network stack. It's == 0 if we sent
+         * and receieved exactly one packet each (in the LLMNR client case). */
 
 #if ENABLE_DNS_OVER_TLS
         if (s->encrypted) {