From: Amos Jeffries Date: Fri, 26 Aug 2011 16:50:49 +0000 (-0600) Subject: Portability: Drop u_short type X-Git-Tag: take08~35^2~14 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f45dd2598fc07c519515a5d1b5b81973a08ff204;p=thirdparty%2Fsquid.git Portability: Drop u_short type Use uint16_t for precise binary size or unsigned short instead. --- diff --git a/compat/getnameinfo.c b/compat/getnameinfo.c index 9dc5e1ce7e..92e423757b 100644 --- a/compat/getnameinfo.c +++ b/compat/getnameinfo.c @@ -156,7 +156,7 @@ int flags; const struct afd *afd; struct servent *sp; struct hostent *hp; - u_short port; + unsigned short port; int family, i; const char *addr; uint32_t v4a; diff --git a/compat/os/mswin.h b/compat/os/mswin.h index 299c2bd7d6..45bcf4bcb2 100644 --- a/compat/os/mswin.h +++ b/compat/os/mswin.h @@ -161,7 +161,6 @@ typedef unsigned long ino_t; #define SIGUSR1 30 /* user defined signal 1 */ #define SIGUSR2 31 /* user defined signal 2 */ -typedef unsigned short int u_short; #if !_SQUID_CYGWIN_ typedef int uid_t; typedef int gid_t; diff --git a/helpers/basic_auth/RADIUS/basic_radius_auth.cc b/helpers/basic_auth/RADIUS/basic_radius_auth.cc index d219551873..23708aebb9 100644 --- a/helpers/basic_auth/RADIUS/basic_radius_auth.cc +++ b/helpers/basic_auth/RADIUS/basic_radius_auth.cc @@ -165,7 +165,7 @@ md5_calc(uint8_t out[16], void *in, size_t len) * Receive and verify the result. */ static int -result_recv(uint32_t host, u_short udp_port, char *buffer, int length) +result_recv(uint32_t host, unsigned short udp_port, char *buffer, int length) { AUTH_HDR *auth; int totallen; @@ -280,7 +280,7 @@ static int authenticate(int socket_fd, const char *username, const char *passwd) { AUTH_HDR *auth; - u_short total_length; + unsigned short total_length; u_char *ptr; int length; char passbuf[MAXPASS]; @@ -445,7 +445,7 @@ main(int argc, char **argv) struct sockaddr_in salocal; struct sockaddr_in saremote; struct servent *svp; - u_short svc_port; + unsigned short svc_port; char username[MAXPWNAM]; char passwd[MAXPASS]; char *ptr; @@ -510,7 +510,7 @@ main(int argc, char **argv) */ svp = getservbyname(svc_name, "udp"); if (svp != NULL) - svc_port = ntohs((u_short) svp->s_port); + svc_port = ntohs((unsigned short) svp->s_port); else svc_port = atoi(svc_name); if (svc_port == 0) diff --git a/helpers/basic_auth/RADIUS/radius.h b/helpers/basic_auth/RADIUS/radius.h index aa5f3d6a7c..fc16ed72ee 100644 --- a/helpers/basic_auth/RADIUS/radius.h +++ b/helpers/basic_auth/RADIUS/radius.h @@ -37,7 +37,7 @@ typedef struct pw_auth_hdr { u_char code; u_char id; - u_short length; + uint16_t length; u_char vector[AUTH_VECTOR_LEN]; u_char data[2]; } AUTH_HDR; diff --git a/include/MemPool.h b/include/MemPool.h index 1b0ff5aaa2..6da91221fb 100644 --- a/include/MemPool.h +++ b/include/MemPool.h @@ -57,7 +57,7 @@ /// \ingroup MemPoolsAPI #define MEM_MIN_FREE 32 /// \ingroup MemPoolsAPI -#define MEM_MAX_FREE 65535 /* u_short is max number of items per chunk */ +#define MEM_MAX_FREE 65535 /* unsigned short is max number of items per chunk */ class MemImplementingAllocator; class MemPoolStats; diff --git a/include/MemPoolChunked.h b/include/MemPoolChunked.h index 874f25406c..78b24b83a0 100644 --- a/include/MemPoolChunked.h +++ b/include/MemPoolChunked.h @@ -12,7 +12,7 @@ /// \ingroup MemPoolsAPI #define MEM_MIN_FREE 32 /// \ingroup MemPoolsAPI -#define MEM_MAX_FREE 65535 /* u_short is max number of items per chunk */ +#define MEM_MAX_FREE 65535 /* unsigned short is max number of items per chunk */ class MemChunk; diff --git a/include/snmp_session.h b/include/snmp_session.h index c5f6406760..bf962fae1d 100644 --- a/include/snmp_session.h +++ b/include/snmp_session.h @@ -36,8 +36,8 @@ struct snmp_session { int retries; /* Number of retries before timeout. */ int timeout; /* Number of uS until first timeout, then exponential backoff */ char *peername; /* Domain name or dotted IP address of default peer */ - u_short remote_port; /* UDP port number of peer. */ - u_short local_port; /* My UDP port number, 0 for default, picked randomly */ + unsigned short remote_port; /* UDP port number of peer. */ + unsigned short local_port; /* My UDP port number, 0 for default, picked randomly */ }; #define RECEIVED_MESSAGE 1 diff --git a/lib/ntlmauth/ntlmauth.cc b/lib/ntlmauth/ntlmauth.cc index 4bfa6ebfcf..a53900c994 100644 --- a/lib/ntlmauth/ntlmauth.cc +++ b/lib/ntlmauth/ntlmauth.cc @@ -119,7 +119,7 @@ ntlm_fetch_string(const ntlmhdr *packet, const int32_t packet_size, const strhdr int32_t o; /* offset */ static char buf[NTLM_MAX_FIELD_LENGTH]; lstring rv; - u_short *s, c; + unsigned short *s, c; char *d, *sc; lstring_zero(rv); @@ -135,7 +135,7 @@ ntlm_fetch_string(const ntlmhdr *packet, const int32_t packet_size, const strhdr rv.str = (char *)packet + o; if ((flags & NTLM_NEGOTIATE_ASCII) == 0) { /* UNICODE string */ - s = (u_short *) ((char *) packet + o); + s = (unsigned short *) ((char *) packet + o); rv.str = d = buf; for (l >>= 1; l; s++, l--) { diff --git a/src/ClientDelayConfig.cc b/src/ClientDelayConfig.cc index bdb670da01..61335b03f9 100644 --- a/src/ClientDelayConfig.cc +++ b/src/ClientDelayConfig.cc @@ -49,7 +49,7 @@ void ClientDelayConfig::parsePoolCount() debugs(3, 0, "parse_client_delay_pool_count: multiple client_delay_pools lines, aborting all previous client_delay_pools config"); clean(); } - u_short pools_; + unsigned short pools_; ConfigParser::ParseUShort(&pools_); for (int i = 0; i < pools_; i++) { pools.push_back(ClientDelayPool()); @@ -58,7 +58,7 @@ void ClientDelayConfig::parsePoolCount() void ClientDelayConfig::parsePoolRates() { - u_short pool; + unsigned short pool; ConfigParser::ParseUShort(&pool); if (pool < 1 || pool > pools.size()) { @@ -74,7 +74,7 @@ void ClientDelayConfig::parsePoolRates() void ClientDelayConfig::parsePoolAccess(ConfigParser &parser) { - u_short pool; + unsigned short pool; ConfigParser::ParseUShort(&pool); diff --git a/src/ConfigParser.h b/src/ConfigParser.h index 4d5a25ba6a..3d47369d1f 100644 --- a/src/ConfigParser.h +++ b/src/ConfigParser.h @@ -63,7 +63,7 @@ class ConfigParser public: void destruct(); - static void ParseUShort(u_short *var); + static void ParseUShort(unsigned short *var); static void ParseBool(bool *var); static void ParseString(char **var); static void ParseString(String *var); diff --git a/src/DelayConfig.cc b/src/DelayConfig.cc index 5691aff9a7..9f3c1e76d9 100644 --- a/src/DelayConfig.cc +++ b/src/DelayConfig.cc @@ -52,7 +52,7 @@ void DelayConfig::parsePoolCount() { - u_short pools_; + unsigned short pools_; ConfigParser::ParseUShort(&pools_); DelayPools::pools(pools_); } @@ -60,7 +60,7 @@ DelayConfig::parsePoolCount() void DelayConfig::parsePoolClass() { - u_short pool; + unsigned short pool; ConfigParser::ParseUShort(&pool); @@ -69,7 +69,7 @@ DelayConfig::parsePoolClass() return; } - u_short delay_class_; + unsigned short delay_class_; ConfigParser::ParseUShort(&delay_class_); if (delay_class_ < 1 || delay_class_ > 5) { @@ -85,7 +85,7 @@ DelayConfig::parsePoolClass() void DelayConfig::parsePoolRates() { - u_short pool; + unsigned short pool; ConfigParser::ParseUShort(&pool); if (pool < 1 || pool > DelayPools::pools()) { @@ -106,7 +106,7 @@ DelayConfig::parsePoolRates() void DelayConfig::parsePoolAccess(ConfigParser &parser) { - u_short pool; + unsigned short pool; ConfigParser::ParseUShort(&pool); diff --git a/src/DelayPools.h b/src/DelayPools.h index 4f258cea08..f7ff974e09 100644 --- a/src/DelayPools.h +++ b/src/DelayPools.h @@ -65,7 +65,7 @@ public: static void Init(); static void Update(void *); static unsigned short pools(); - static void pools (u_short pools); + static void pools(unsigned short pools); static void FreePools(); static unsigned char *DelayClasses(); static void registerForUpdates(Updateable *); diff --git a/src/HttpRequest.h b/src/HttpRequest.h index 3de0af7cbb..b9bea3e8c6 100644 --- a/src/HttpRequest.h +++ b/src/HttpRequest.h @@ -148,7 +148,7 @@ public: #if USE_AUTH AuthUserRequest::Pointer auth_user_request; #endif - u_short port; + unsigned short port; String urlpath; diff --git a/src/Parsing.cc b/src/Parsing.cc index b5aef87741..e0371fc145 100644 --- a/src/Parsing.cc +++ b/src/Parsing.cc @@ -111,7 +111,7 @@ GetInteger(void) return i; } -u_short +unsigned short GetShort(void) { char *token = strtok(NULL, w_space); diff --git a/src/Parsing.h b/src/Parsing.h index 9bae0d6d20..2b78a0ca75 100644 --- a/src/Parsing.h +++ b/src/Parsing.h @@ -54,7 +54,7 @@ extern int64_t GetInteger64(void); */ extern int GetInteger(void); -extern u_short GetShort(void); +extern unsigned short GetShort(void); // on success, returns true and sets *p (if any) to the end of the integer extern bool StringToInt(const char *str, int &result, const char **p, int base); diff --git a/src/Store.h b/src/Store.h index 48fd9a31ac..c24b50cc0a 100644 --- a/src/Store.h +++ b/src/Store.h @@ -152,15 +152,15 @@ public: time_t expires; time_t lastmod; uint64_t swap_file_sz; - u_short refcount; - u_short flags; + uint16_t refcount; + uint16_t flags; /* END OF ON-DISK STORE_META_STD */ sfileno swap_filen:25; sdirno swap_dirn:7; - u_short lock_count; /* Assume < 65536! */ + unsigned short lock_count; /* Assume < 65536! */ mem_status_t mem_status:3; diff --git a/src/StoreMeta.h b/src/StoreMeta.h index 0cecba927e..250ae2d686 100644 --- a/src/StoreMeta.h +++ b/src/StoreMeta.h @@ -98,9 +98,9 @@ enum { time_t lastref; time_t expires; time_t lastmod; - size_t swap_file_sz; - u_short refcount; - u_short flags; + uint64_t swap_file_sz; + uint16_t refcount; + uint16_t flags; \endcode */ STORE_META_STD, diff --git a/src/StoreSwapLogData.h b/src/StoreSwapLogData.h index dbd576bc4d..5fad46944f 100644 --- a/src/StoreSwapLogData.h +++ b/src/StoreSwapLogData.h @@ -146,14 +146,14 @@ public: * Since its a 16-bit quantity, it is susceptible to overflow * if a single object is accessed 65,536 times before being replaced. */ - u_short refcount; + uint16_t refcount; /** * A copy of the StoreEntry flags field. Used as a sanity * check when rebuilding the cache at startup. Objects that * have the KEY_PRIVATE flag set are not added back to the cache. */ - u_short flags; + uint16_t flags; /** * The 128-bit MD5 hash for this object. diff --git a/src/cache_cf.cc b/src/cache_cf.cc index 40f3eb8e2b..2a67a0e24e 100644 --- a/src/cache_cf.cc +++ b/src/cache_cf.cc @@ -147,7 +147,7 @@ static void configDoConfigure(void); static void parse_refreshpattern(refresh_t **); static uint64_t parseTimeUnits(const char *unit, bool allowMsec); static void parseTimeLine(time_msec_t * tptr, const char *units, bool allowMsec); -static void parse_u_short(u_short * var); +static void parse_u_short(unsigned short * var); static void parse_string(char **); static void default_all(void); static void defaults_if_none(void); @@ -2090,7 +2090,7 @@ isUnsignedNumeric(const char *str, size_t len) \param proto 'tcp' or 'udp' for protocol \returns Port the named service is supposed to be listening on. */ -static u_short +static unsigned short GetService(const char *proto) { struct servent *port = NULL; @@ -2104,7 +2104,7 @@ GetService(const char *proto) if ( !isUnsignedNumeric(token, strlen(token)) ) port = getservbyname(token, proto); if (port != NULL) { - return ntohs((u_short)port->s_port); + return ntohs((unsigned short)port->s_port); } /** Or a numeric translation of the config text. */ return xatos(token); @@ -2114,7 +2114,7 @@ GetService(const char *proto) \returns Port the named TCP service is supposed to be listening on. \copydoc GetService(const char *proto) */ -inline u_short +inline unsigned short GetTcpService(void) { return GetService("tcp"); @@ -2124,7 +2124,7 @@ GetTcpService(void) \returns Port the named UDP service is supposed to be listening on. \copydoc GetService(const char *proto) */ -inline u_short +inline unsigned short GetUdpService(void) { return GetService("udp"); @@ -3195,25 +3195,25 @@ free_b_int64_t(int64_t * var) #define free_kb_int64_t free_b_int64_t static void -dump_u_short(StoreEntry * entry, const char *name, u_short var) +dump_u_short(StoreEntry * entry, const char *name, unsigned short var) { storeAppendPrintf(entry, "%s %d\n", name, var); } static void -free_u_short(u_short * u) +free_u_short(unsigned short * u) { *u = 0; } static void -parse_u_short(u_short * var) +parse_u_short(unsigned short * var) { ConfigParser::ParseUShort(var); } void -ConfigParser::ParseUShort(u_short *var) +ConfigParser::ParseUShort(unsigned short *var) { *var = GetShort(); } diff --git a/src/comm.cc b/src/comm.cc index a6ab545de7..4b0938510b 100644 --- a/src/comm.cc +++ b/src/comm.cc @@ -362,7 +362,7 @@ comm_has_incomplete_write(int fd) */ /* Return the local port associated with fd. */ -u_short +unsigned short comm_local_port(int fd) { Ip::Address temp; @@ -644,7 +644,7 @@ comm_apply_flags(int new_socket, if ((flags & COMM_REUSEADDR)) commSetReuseAddr(new_socket); - if (addr.GetPort() > (u_short) 0) { + if (addr.GetPort() > (unsigned short) 0) { #if _SQUID_MSWIN_ if (sock_type != SOCK_DGRAM) #endif @@ -703,7 +703,7 @@ comm_import_opened(const Comm::ConnectionPointer &conn, if (!(conn->flags & COMM_NOCLOEXEC)) fd_table[conn->fd].flags.close_on_exec = 1; - if (conn->local.GetPort() > (u_short) 0) { + if (conn->local.GetPort() > (unsigned short) 0) { #if _SQUID_MSWIN_ if (AI->ai_socktype != SOCK_DGRAM) #endif diff --git a/src/comm.h b/src/comm.h index 322d22ec93..c4355e5975 100644 --- a/src/comm.h +++ b/src/comm.h @@ -52,7 +52,7 @@ extern int comm_open_listener(int sock_type, int proto, Ip::Address &addr, int f extern void comm_open_listener(int sock_type, int proto, Comm::ConnectionPointer &conn, const char *note); SQUIDCEXTERN int comm_openex(int, int, Ip::Address &, int, tos_t tos, nfmark_t nfmark, const char *); -SQUIDCEXTERN u_short comm_local_port(int fd); +SQUIDCEXTERN unsigned short comm_local_port(int fd); SQUIDCEXTERN int comm_udp_sendto(int sock, const Ip::Address &to, const void *buf, int buflen); SQUIDCEXTERN void commCallCloseHandlers(int fd); diff --git a/src/defines.h b/src/defines.h index c0e2c87aa7..5d9a81d0d4 100644 --- a/src/defines.h +++ b/src/defines.h @@ -192,8 +192,8 @@ #define SwapMetaType(x) (char)x[0] #define SwapMetaSize(x) &x[sizeof(char)] #define SwapMetaData(x) &x[STORE_META_TLD_START] -#define STORE_HDR_METASIZE (4*sizeof(time_t)+2*sizeof(u_short)+sizeof(uint64_t)) -#define STORE_HDR_METASIZE_OLD (4*sizeof(time_t)+2*sizeof(u_short)+sizeof(size_t)) +#define STORE_HDR_METASIZE (4*sizeof(time_t)+2*sizeof(uint16_t)+sizeof(uint64_t)) +#define STORE_HDR_METASIZE_OLD (4*sizeof(time_t)+2*sizeof(uint16_t)+sizeof(size_t)) #define COUNT_INTERVAL 60 /* diff --git a/src/delay_pools.cc b/src/delay_pools.cc index 56a2561003..890e3fdb39 100644 --- a/src/delay_pools.cc +++ b/src/delay_pools.cc @@ -669,7 +669,7 @@ DelayPools::pools() } void -DelayPools::pools (u_short newPools) +DelayPools::pools(unsigned short newPools) { if (pools()) { debugs(3, 0, "parse_delay_pool_count: multiple delay_pools lines, aborting all previous delay_pools config"); diff --git a/src/errorpage.h b/src/errorpage.h index 8eb3cb0cae..5d76575e80 100644 --- a/src/errorpage.h +++ b/src/errorpage.h @@ -151,7 +151,7 @@ public: HttpRequest *request; char *url; int xerrno; - u_short port; + unsigned short port; String dnsError; ///< DNS lookup error message time_t ttl; diff --git a/src/fde.h b/src/fde.h index 94cf3568df..f7ffa1c0c4 100644 --- a/src/fde.h +++ b/src/fde.h @@ -57,7 +57,7 @@ public: public: unsigned int type; - u_short remote_port; + unsigned short remote_port; Ip::Address local_addr; tos_t tosToServer; /**< The TOS value for packets going towards the server. diff --git a/src/fs/ufs/ufscommon.cc b/src/fs/ufs/ufscommon.cc index 5c89a1d2ee..2fdceacd65 100644 --- a/src/fs/ufs/ufscommon.cc +++ b/src/fs/ufs/ufscommon.cc @@ -63,8 +63,8 @@ public: time_t expires; time_t lastmod; uint32_t swap_file_sz; - u_short refcount; - u_short flags; + uint16_t refcount; + uint16_t flags; unsigned char key[SQUID_MD5_DIGEST_LENGTH]; }; UFSSwapLogParser_v1_32bs(FILE *fp):UFSSwapLogParser(fp) { @@ -111,8 +111,8 @@ public: int32_t expires; int32_t lastmod; uint32_t swap_file_sz; - u_short refcount; - u_short flags; + uint16_t refcount; + uint16_t flags; unsigned char key[SQUID_MD5_DIGEST_LENGTH]; }; UFSSwapLogParser_v1_32bst(FILE *fp):UFSSwapLogParser(fp) { @@ -157,8 +157,8 @@ public: time_t expires; time_t lastmod; uint64_t swap_file_sz; - u_short refcount; - u_short flags; + uint16_t refcount; + uint16_t flags; unsigned char key[SQUID_MD5_DIGEST_LENGTH]; }; UFSSwapLogParser_v1_64bfn(FILE *fp):UFSSwapLogParser(fp) { @@ -380,8 +380,8 @@ struct InitStoreEntry : public unary_function { time_t expires; time_t lastmod; size_t swap_file_sz; - u_short refcount; - u_short flags; + uint16_t refcount; + uint16_t flags; } *tmp; tmp = (struct old_metahdr *)x.value; assert(x.length == STORE_HDR_METASIZE_OLD); diff --git a/src/ftp.cc b/src/ftp.cc index ee86185d0d..150c4edaad 100644 --- a/src/ftp.cc +++ b/src/ftp.cc @@ -223,7 +223,7 @@ public: struct DataChannel: public FtpChannel { MemBuf *readBuf; char *host; - u_short port; + unsigned short port; bool read_pending; } data; @@ -2431,7 +2431,7 @@ ftpReadEPSV(FtpStateData* ftpState) buf = ftpState->ctrl.last_reply + strcspn(ftpState->ctrl.last_reply, "("); char h1, h2, h3, h4; - u_short port; + unsigned short port; int n = sscanf(buf, "(%c%c%c%hu%c)", &h1, &h2, &h3, &port, &h4); if (n < 4 || h1 != h2 || h1 != h3 || h1 != h4) { @@ -2644,7 +2644,7 @@ ftpReadPasv(FtpStateData * ftpState) int h1, h2, h3, h4; int p1, p2; int n; - u_short port; + unsigned short port; Ip::Address ipa_remote; char *buf; LOCAL_ARRAY(char, ipaddr, 1024); diff --git a/src/htcp.cc b/src/htcp.cc index 96c67fc1a7..5c5fbd90dd 100644 --- a/src/htcp.cc +++ b/src/htcp.cc @@ -467,12 +467,12 @@ htcpBuildTstOpData(char *buf, size_t buflen, htcpStuff * stuff) static ssize_t htcpBuildClrOpData(char *buf, size_t buflen, htcpStuff * stuff) { - u_short reason; + unsigned short reason; switch (stuff->rr) { case RR_REQUEST: debugs(31, 3, "htcpBuildClrOpData: RR_REQUEST"); - reason = htons((u_short)stuff->reason); + reason = htons((unsigned short)stuff->reason); memcpy(buf, &reason, 2); return htcpBuildSpecifier(buf + 2, buflen - 2, stuff) + 2; case RR_RESPONSE: diff --git a/src/icmp/Icmp4.cc b/src/icmp/Icmp4.cc index e2edfc8a13..f506d7ace4 100644 --- a/src/icmp/Icmp4.cc +++ b/src/icmp/Icmp4.cc @@ -117,7 +117,7 @@ Icmp4::SendEcho(Ip::Address &to, int opcode, const char *payload, int len) icmp->icmp_code = 0; icmp->icmp_cksum = 0; icmp->icmp_id = icmp_ident; - icmp->icmp_seq = (u_short) icmp_pkts_sent++; + icmp->icmp_seq = (unsigned short) icmp_pkts_sent++; // Construct ICMP packet data content echo = (icmpEchoData *) (icmp + 1); @@ -135,7 +135,7 @@ Icmp4::SendEcho(Ip::Address &to, int opcode, const char *payload, int len) icmp_pktsize += len; } - icmp->icmp_cksum = CheckSum((u_short *) icmp, icmp_pktsize); + icmp->icmp_cksum = CheckSum((unsigned short *) icmp, icmp_pktsize); to.GetAddrInfo(S); ((sockaddr_in*)S->ai_addr)->sin_port = 0; diff --git a/src/icmp/Icmp6.cc b/src/icmp/Icmp6.cc index 21dc01fedd..d8dcaa4b20 100644 --- a/src/icmp/Icmp6.cc +++ b/src/icmp/Icmp6.cc @@ -158,7 +158,7 @@ Icmp6::SendEcho(Ip::Address &to, int opcode, const char *payload, int len) icmp->icmp6_code = 0; icmp->icmp6_cksum = 0; icmp->icmp6_id = icmp_ident; - icmp->icmp6_seq = (u_short) icmp_pkts_sent++; + icmp->icmp6_seq = (unsigned short) icmp_pkts_sent++; icmp6_pktsize = sizeof(struct icmp6_hdr); @@ -179,7 +179,7 @@ Icmp6::SendEcho(Ip::Address &to, int opcode, const char *payload, int len) icmp6_pktsize += len; } - icmp->icmp6_cksum = CheckSum((u_short *) icmp, icmp6_pktsize); + icmp->icmp6_cksum = CheckSum((unsigned short *) icmp, icmp6_pktsize); to.GetAddrInfo(S); ((sockaddr_in6*)S->ai_addr)->sin6_port = 0; diff --git a/src/internal.cc b/src/internal.cc index 4e5be31c04..8976164b5b 100644 --- a/src/internal.cc +++ b/src/internal.cc @@ -97,7 +97,7 @@ internalStaticCheck(const char *urlpath) * makes internal url with a given host and port (remote internal url) */ char * -internalRemoteUri(const char *host, u_short port, const char *dir, const char *name) +internalRemoteUri(const char *host, unsigned short port, const char *dir, const char *name) { static char lc_host[SQUIDHOSTNAMELEN]; assert(host && name); diff --git a/src/ip/Address.cc b/src/ip/Address.cc index a81da56bfb..d5095d88ac 100644 --- a/src/ip/Address.cc +++ b/src/ip/Address.cc @@ -791,14 +791,14 @@ Ip::Address::operator <(const Ip::Address &rhs) const return ( matchIPAddr(rhs) < 0); } -u_short +unsigned short Ip::Address::GetPort() const { return ntohs( m_SocketAddr.sin6_port ); } -u_short -Ip::Address::SetPort(u_short prt) +unsigned short +Ip::Address::SetPort(unsigned short prt) { m_SocketAddr.sin6_port = htons(prt); diff --git a/src/ip/Address.h b/src/ip/Address.h index 8792d9c589..512ffd40e7 100644 --- a/src/ip/Address.h +++ b/src/ip/Address.h @@ -184,7 +184,7 @@ public: \retval 0 Port is unset or an error occured. \retval n Port associated with this address in host native -endian. */ - u_short GetPort() const; + unsigned short GetPort() const; /** Set the Port value for an address. * Replaces any previously existing Port value. @@ -192,7 +192,7 @@ public: \retval 0 Port is unset or an error occured. \retval n Port associated with this address in host native -endian. */ - u_short SetPort(u_short port); + unsigned short SetPort(unsigned short port); /// Set object to contain the specific IP case ANY_ADDR (format-neutral). /// see IsAnyAddr() for more detail. diff --git a/src/ip/testAddress.cc b/src/ip/testAddress.cc index 310d201ee8..180a0c2df4 100644 --- a/src/ip/testAddress.cc +++ b/src/ip/testAddress.cc @@ -43,7 +43,7 @@ testIpAddress::testDefaults() CPPUNIT_ASSERT( !anIPA.IsNoAddr() ); CPPUNIT_ASSERT( !anIPA.IsIPv4() ); CPPUNIT_ASSERT( !anIPA.IsSockAddr() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , anIPA.GetPort() ); CPPUNIT_ASSERT( anIPA.IsIPv6() ); } @@ -64,7 +64,7 @@ testIpAddress::testInAddrConstructor() CPPUNIT_ASSERT( anIPA.IsIPv4() ); CPPUNIT_ASSERT( !anIPA.IsIPv6() ); CPPUNIT_ASSERT( !anIPA.IsSockAddr() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , anIPA.GetPort() ); anIPA.GetInAddr(outval); CPPUNIT_ASSERT( memcmp(&inval, &outval, sizeof(struct in_addr)) == 0 ); } @@ -88,7 +88,7 @@ testIpAddress::testInAddr6Constructor() CPPUNIT_ASSERT( !anIPA.IsIPv4() ); CPPUNIT_ASSERT( anIPA.IsIPv6() ); CPPUNIT_ASSERT( !anIPA.IsSockAddr() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , anIPA.GetPort() ); anIPA.GetInAddr(outval); CPPUNIT_ASSERT( memcmp( &inval, &outval, sizeof(struct in6_addr)) == 0 ); } @@ -117,7 +117,7 @@ testIpAddress::testSockAddrConstructor() CPPUNIT_ASSERT( anIPA.IsIPv4() ); CPPUNIT_ASSERT( !anIPA.IsIPv6() ); CPPUNIT_ASSERT( anIPA.IsSockAddr() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 80 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 80 , anIPA.GetPort() ); anIPA.GetSockAddr(outsock); CPPUNIT_ASSERT( memcmp( &insock, &outsock, sizeof(struct sockaddr_in)) == 0 ); } @@ -149,7 +149,7 @@ testIpAddress::testSockAddr6Constructor() CPPUNIT_ASSERT( !anIPA.IsIPv4() ); CPPUNIT_ASSERT( anIPA.IsIPv6() ); CPPUNIT_ASSERT( anIPA.IsSockAddr() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 80 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 80 , anIPA.GetPort() ); anIPA.GetSockAddr(outsock); CPPUNIT_ASSERT( memcmp( &insock, &outsock, sizeof(struct sockaddr_in6)) == 0 ); } @@ -181,7 +181,7 @@ testIpAddress::testCopyConstructor() CPPUNIT_ASSERT( outIPA.IsIPv4() ); CPPUNIT_ASSERT( !outIPA.IsIPv6() ); CPPUNIT_ASSERT( outIPA.IsSockAddr() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 80 , outIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 80 , outIPA.GetPort() ); outIPA.GetSockAddr(outsock); CPPUNIT_ASSERT( memcmp( &insock, &outsock, sizeof(struct sockaddr_in)) == 0 ); } @@ -206,7 +206,7 @@ testIpAddress::testHostentConstructor() CPPUNIT_ASSERT( anIPA.IsIPv4() ); CPPUNIT_ASSERT( !anIPA.IsIPv6() ); CPPUNIT_ASSERT( !anIPA.IsSockAddr() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , anIPA.GetPort() ); anIPA.GetInAddr(outval); CPPUNIT_ASSERT( memcmp( &expectval, &outval, sizeof(struct in_addr)) == 0 ); } @@ -226,7 +226,7 @@ testIpAddress::testStringConstructor() CPPUNIT_ASSERT( !anIPA.IsNoAddr() ); CPPUNIT_ASSERT( anIPA.IsIPv4() ); CPPUNIT_ASSERT( !anIPA.IsIPv6() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , anIPA.GetPort() ); CPPUNIT_ASSERT( !anIPA.IsSockAddr() ); anIPA.GetInAddr(outval); CPPUNIT_ASSERT( memcmp( &expectval, &outval, sizeof(struct in_addr)) == 0 ); @@ -251,7 +251,7 @@ testIpAddress::testStringConstructor() CPPUNIT_ASSERT( !bnIPA.IsIPv4() ); CPPUNIT_ASSERT( bnIPA.IsIPv6() ); CPPUNIT_ASSERT( !bnIPA.IsSockAddr() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , bnIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , bnIPA.GetPort() ); bnIPA.GetInAddr(outval6); CPPUNIT_ASSERT( memcmp( &expectv6, &outval6, sizeof(struct in6_addr)) == 0 ); @@ -269,7 +269,7 @@ testIpAddress::testStringConstructor() CPPUNIT_ASSERT( !cnIPA.IsIPv4() ); CPPUNIT_ASSERT( cnIPA.IsIPv6() ); CPPUNIT_ASSERT( !cnIPA.IsSockAddr() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , cnIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , cnIPA.GetPort() ); cnIPA.GetInAddr(outval6); CPPUNIT_ASSERT( memcmp( &expectv6, &outval6, sizeof(struct in6_addr)) == 0 ); } @@ -290,7 +290,7 @@ testIpAddress::testSetEmpty() CPPUNIT_ASSERT( anIPA.IsIPv4() ); CPPUNIT_ASSERT( !anIPA.IsIPv6() ); CPPUNIT_ASSERT( !anIPA.IsSockAddr() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , anIPA.GetPort() ); anIPA.SetEmpty(); @@ -300,7 +300,7 @@ testIpAddress::testSetEmpty() CPPUNIT_ASSERT( !anIPA.IsIPv4() ); CPPUNIT_ASSERT( anIPA.IsIPv6() ); CPPUNIT_ASSERT( !anIPA.IsSockAddr() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , anIPA.GetPort() ); } void @@ -740,7 +740,7 @@ testIpAddress::testBugNullingDisplay() CPPUNIT_ASSERT( !anIPA.IsNoAddr() ); CPPUNIT_ASSERT( anIPA.IsIPv4() ); CPPUNIT_ASSERT( !anIPA.IsIPv6() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , anIPA.GetPort() ); CPPUNIT_ASSERT( !anIPA.IsSockAddr() ); anIPA.GetInAddr(outval); CPPUNIT_ASSERT( memcmp( &expectval, &outval, sizeof(struct in_addr)) == 0 ); @@ -754,7 +754,7 @@ testIpAddress::testBugNullingDisplay() CPPUNIT_ASSERT( !anIPA.IsNoAddr() ); CPPUNIT_ASSERT( anIPA.IsIPv4() ); CPPUNIT_ASSERT( !anIPA.IsIPv6() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , anIPA.GetPort() ); CPPUNIT_ASSERT( !anIPA.IsSockAddr() ); anIPA.GetInAddr(outval); CPPUNIT_ASSERT( memcmp( &expectval, &outval, sizeof(struct in_addr)) == 0 ); @@ -769,7 +769,7 @@ testIpAddress::testBugNullingDisplay() CPPUNIT_ASSERT( !anIPA.IsNoAddr() ); CPPUNIT_ASSERT( anIPA.IsIPv4() ); CPPUNIT_ASSERT( !anIPA.IsIPv6() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , anIPA.GetPort() ); CPPUNIT_ASSERT( !anIPA.IsSockAddr() ); anIPA.GetInAddr(outval); CPPUNIT_ASSERT( memcmp( &expectval, &outval, sizeof(struct in_addr)) == 0 ); @@ -783,7 +783,7 @@ testIpAddress::testBugNullingDisplay() CPPUNIT_ASSERT( !anIPA.IsNoAddr() ); CPPUNIT_ASSERT( anIPA.IsIPv4() ); CPPUNIT_ASSERT( !anIPA.IsIPv6() ); - CPPUNIT_ASSERT_EQUAL( (u_short) 0 , anIPA.GetPort() ); + CPPUNIT_ASSERT_EQUAL( (unsigned short) 0 , anIPA.GetPort() ); CPPUNIT_ASSERT( !anIPA.IsSockAddr() ); anIPA.GetInAddr(outval); CPPUNIT_ASSERT( memcmp( &expectval, &outval, sizeof(struct in_addr)) == 0 ); diff --git a/src/main.cc b/src/main.cc index 64531ce800..f56501bcdb 100644 --- a/src/main.cc +++ b/src/main.cc @@ -984,7 +984,7 @@ mainInitialize(void) setEffectiveUser(); if (icpPortNumOverride != 1) - Config.Port.icp = (u_short) icpPortNumOverride; + Config.Port.icp = (unsigned short) icpPortNumOverride; _db_init(Debug::cache_log, Debug::debugOptions); diff --git a/src/neighbors.cc b/src/neighbors.cc index 2c32190e47..2254f56927 100644 --- a/src/neighbors.cc +++ b/src/neighbors.cc @@ -77,7 +77,7 @@ static OBJH neighborDumpPeers; static OBJH neighborDumpNonPeers; static void dump_peers(StoreEntry * sentry, peer * peers); -static u_short echo_port; +static unsigned short echo_port; static int NLateReplies = 0; static peer *first_ping = NULL; @@ -565,7 +565,7 @@ neighbors_init(void) peerRefreshDNS((void *) 1); sep = getservbyname("echo", "udp"); - echo_port = sep ? ntohs((u_short) sep->s_port) : 7; + echo_port = sep ? ntohs((unsigned short) sep->s_port) : 7; first_ping = Config.peers; } diff --git a/src/protos.h b/src/protos.h index 957a6aa217..858b42acbc 100644 --- a/src/protos.h +++ b/src/protos.h @@ -599,7 +599,7 @@ SQUIDCEXTERN char *urlCanonicalClean(const HttpRequest *); SQUIDCEXTERN const char *urlCanonicalFakeHttps(const HttpRequest * request); SQUIDCEXTERN bool urlIsRelative(const char *); SQUIDCEXTERN char *urlMakeAbsolute(const HttpRequest *, const char *); -SQUIDCEXTERN char *urlRInternal(const char *host, u_short port, const char *dir, const char *name); +SQUIDCEXTERN char *urlRInternal(const char *host, unsigned short port, const char *dir, const char *name); SQUIDCEXTERN char *urlInternal(const char *dir, const char *name); SQUIDCEXTERN int matchDomainName(const char *host, const char *domain); SQUIDCEXTERN int urlCheckRequest(const HttpRequest *); @@ -665,7 +665,7 @@ SQUIDCEXTERN void internalStart(const Comm::ConnectionPointer &clientConn, HttpR SQUIDCEXTERN int internalCheck(const char *urlpath); SQUIDCEXTERN int internalStaticCheck(const char *urlpath); SQUIDCEXTERN char *internalLocalUri(const char *dir, const char *name); -SQUIDCEXTERN char *internalRemoteUri(const char *, u_short, const char *, const char *); +SQUIDCEXTERN char *internalRemoteUri(const char *, unsigned short, const char *, const char *); SQUIDCEXTERN const char *internalHostname(void); SQUIDCEXTERN int internalHostnameIs(const char *); diff --git a/src/send-announce.cc b/src/send-announce.cc index 085203d523..03ea3e5624 100644 --- a/src/send-announce.cc +++ b/src/send-announce.cc @@ -65,7 +65,7 @@ send_announce(const ipcache_addrs *ia, const DnsLookupDetails &, void *junk) char *host = Config.Announce.host; char *file = NULL; - u_short port = Config.Announce.port; + unsigned short port = Config.Announce.port; int l; int n; int fd; diff --git a/src/structs.h b/src/structs.h index c485816841..0cc7c26067 100644 --- a/src/structs.h +++ b/src/structs.h @@ -117,7 +117,7 @@ struct acl_size_t { }; struct ushortlist { - u_short i; + unsigned short i; ushortlist *next; }; @@ -206,14 +206,14 @@ struct SquidConfig { acl_size_t *ReplyBodySize; struct { - u_short icp; + unsigned short icp; #if USE_HTCP - u_short htcp; + unsigned short htcp; #endif #if SQUID_SNMP - u_short snmp; + unsigned short snmp; #endif } Port; @@ -322,7 +322,7 @@ struct SquidConfig { char *host; char *file; time_t period; - u_short port; + unsigned short port; } Announce; struct { @@ -815,18 +815,18 @@ struct peer { struct { int version; int counts[ICP_END+1]; - u_short port; + unsigned short port; } icp; #if USE_HTCP struct { double version; int counts[2]; - u_short port; + unsigned short port; } htcp; #endif - u_short http_port; + unsigned short http_port; domain_ping *peer_domain; domain_type *typelist; acl_access *access; diff --git a/src/tests/stub_cache_cf.cc b/src/tests/stub_cache_cf.cc index 9c3e7fb7ca..9844b745fa 100644 --- a/src/tests/stub_cache_cf.cc +++ b/src/tests/stub_cache_cf.cc @@ -104,7 +104,7 @@ strtokFile(void) } void -ConfigParser::ParseUShort(u_short *var) +ConfigParser::ParseUShort(unsigned short *var) { fatal("not implemented 10"); } diff --git a/src/tests/testHttpRequest.cc b/src/tests/testHttpRequest.cc index a2337de040..01d0a3c6de 100644 --- a/src/tests/testHttpRequest.cc +++ b/src/tests/testHttpRequest.cc @@ -33,7 +33,7 @@ void testHttpRequest::testCreateFromUrlAndMethod() { /* vanilla url */ - u_short expected_port; + unsigned short expected_port; char * url = xstrdup("http://foo:90/bar"); HttpRequest *aRequest = HttpRequest::CreateFromUrlAndMethod(url, METHOD_GET); expected_port = 90; @@ -83,7 +83,7 @@ void testHttpRequest::testCreateFromUrl() { /* vanilla url */ - u_short expected_port; + unsigned short expected_port; char * url = xstrdup("http://foo:90/bar"); HttpRequest *aRequest = HttpRequest::CreateFromUrl(url); expected_port = 90; @@ -102,7 +102,7 @@ testHttpRequest::testCreateFromUrl() void testHttpRequest::testIPv6HostColonBug() { - u_short expected_port; + unsigned short expected_port; char * url = NULL; HttpRequest *aRequest = NULL; diff --git a/src/ufsdump.cc b/src/ufsdump.cc index 401cbdb6bb..a3545de45e 100644 --- a/src/ufsdump.cc +++ b/src/ufsdump.cc @@ -98,8 +98,8 @@ struct MetaStd { time_t expires; time_t lastmod; size_t swap_file_sz; - u_short refcount; - u_short flags; + uint16_t refcount; + uint16_t flags; }; struct MetaStdLfs { @@ -108,8 +108,8 @@ struct MetaStdLfs { time_t expires; time_t lastmod; uint64_t swap_file_sz; - u_short refcount; - u_short flags; + uint16_t refcount; + uint16_t flags; }; struct DumpStoreMeta : public unary_function { diff --git a/src/url.cc b/src/url.cc index 6abba4006e..ee1ec393ab 100644 --- a/src/url.cc +++ b/src/url.cc @@ -447,7 +447,7 @@ urlParseFinish(const HttpRequestMethod& method, request->SetHost(host); xstrncpy(request->login, login, MAX_LOGIN_SZ); - request->port = (u_short) port; + request->port = (unsigned short) port; return request; } diff --git a/src/wccp2.cc b/src/wccp2.cc index 518dbe998b..4e952aa09b 100644 --- a/src/wccp2.cc +++ b/src/wccp2.cc @@ -1630,7 +1630,7 @@ wccp2AssignBuckets(void *voidnotused) int router_len; int bucket_counter; uint32_t service_flags; - u_short port = WCCP_PORT; + unsigned short port = WCCP_PORT; /* Packet segments */ diff --git a/tools/purge/squid-tlv.hh b/tools/purge/squid-tlv.hh index a8531d2c19..1d9316d97e 100644 --- a/tools/purge/squid-tlv.hh +++ b/tools/purge/squid-tlv.hh @@ -78,8 +78,8 @@ struct StoreMetaStd { time_t expires; time_t lastmod; size_t swap_file_sz; - u_short refcount; - u_short flags; + uint16_t refcount; + uint16_t flags; }; struct StoreMetaStdLFS { @@ -87,9 +87,9 @@ struct StoreMetaStdLFS { time_t lastref; time_t expires; time_t lastmod; - uint64_t swap_file_sz; - u_short refcount; - u_short flags; + uint64_t swap_file_sz; + uint16_t refcount; + uint16_t flags; }; struct SquidTLV {