From: Frédéric Buclin <LpSolit@gmail.com>
Date: Thu, 14 Oct 2010 00:33:49 +0000 (+0200)
Subject: Bug 600598: "Can't call method "bug_list" on unblessed reference" error thrown when... 
X-Git-Tag: bugzilla-4.0rc1~34
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f46445b26043d267d9a25d0dfde7b289bafdc087;p=thirdparty%2Fbugzilla.git

Bug 600598: "Can't call method "bug_list" on unblessed reference" error thrown when editing a bug which is in the BUGLIST cookie but not in a recent saved search, with action="next_bug"
r/a=mkanat
---

diff --git a/Bugzilla/Search/Recent.pm b/Bugzilla/Search/Recent.pm
index 6e24bd5bc7..d7d595ecc4 100644
--- a/Bugzilla/Search/Recent.pm
+++ b/Bugzilla/Search/Recent.pm
@@ -90,6 +90,18 @@ sub check {
     return $search;
 }
 
+sub new_from_cookie {
+    my ($invocant, $bug_ids) = @_;
+    my $class = ref($invocant) || $invocant;
+
+    my $search = { id       => 'cookie',
+                   user_id  => Bugzilla->user->id,
+                   bug_list => join(',', @$bug_ids) };
+
+    bless $search, $class;
+    return $search;
+}
+
 ####################
 # Simple Accessors #
 ####################
diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm
index 50e44fcd24..10f7cc4981 100644
--- a/Bugzilla/User.pm
+++ b/Bugzilla/User.pm
@@ -425,7 +425,8 @@ sub recent_search_for {
     if (my $list = $cgi->cookie('BUGLIST')) {
         my @bug_ids = split(':', $list);
         if (grep { $_ == $bug->id } @bug_ids) {
-            return { id => 'cookie', bug_list => \@bug_ids };
+            my $search = Bugzilla::Search::Recent->new_from_cookie(\@bug_ids);
+            return $search;
         }
     }