From: Ben Darnell <ben@bendarnell.com>
Date: Thu, 14 Jun 2012 06:08:06 +0000 (-0700)
Subject: Better way to force a getaddrinfo error.
X-Git-Tag: v2.4.0~67
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f48578cce3f9e1978554a1bcd2c82a7403bcd6c7;p=thirdparty%2Ftornado.git

Better way to force a getaddrinfo error.

This fixes the tests for users behind misbehaving DNS servers.

Closes #534.
---

diff --git a/tornado/test/iostream_test.py b/tornado/test/iostream_test.py
index f62e4801c..4bb4f21ce 100644
--- a/tornado/test/iostream_test.py
+++ b/tornado/test/iostream_test.py
@@ -103,7 +103,11 @@ class TestIOStream(AsyncHTTPTestCase, LogTrapTestCase):
         s = socket.socket(socket.AF_INET, socket.SOCK_STREAM, 0)
         stream = IOStream(s, io_loop=self.io_loop)
         stream.set_close_callback(self.stop)
-        stream.connect(('adomainthatdoesntexist.asdf', 54321))
+        # To reliably generate a gaierror we use a malformed domain name
+        # instead of a name that's simply unlikely to exist (since
+        # opendns and some ISPs return bogus addresses for nonexistent
+        # domains instead of the proper error codes).
+        stream.connect(('an invalid domain', 54321))
         self.assertTrue(isinstance(stream.error, socket.gaierror), stream.error)
 
     def test_connection_closed(self):