From: Jim Meyering <jim@meyering.net>
Date: Thu, 22 Feb 2007 11:50:36 +0000 (+0100)
Subject: Placate valgrind, wrt ./cp --sparse=always
X-Git-Tag: COREUTILS-6_8~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f48ca7f500cd55e88f9fa24ec8ef74d6bed25a69;p=thirdparty%2Fcoreutils.git

Placate valgrind, wrt ./cp --sparse=always
* src/copy.c (copy_reg): Place the sentinel by setting a
full word's worth of bits, not just a single byte's worth.
This avoids a harmless (but distracting) case of memory being
used-uninitialized.
---

diff --git a/ChangeLog b/ChangeLog
index d0d0fda947..ec598a0119 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2007-02-22  Jim Meyering  <jim@meyering.net>
+
+	Placate valgrind, wrt ./cp --sparse=always
+	* src/copy.c (copy_reg): Place the sentinel by setting a
+	full word's worth of bits, not just a single byte's worth.
+	This avoids a harmless (but distracting) case of memory being
+	used-uninitialized.
+
 2007-02-21  Jim Meyering  <jim@meyering.net>
 
 	* tests/misc/date: Remove vestigial use of Data::Dumper.
diff --git a/src/copy.c b/src/copy.c
index a3489c399b..f0c6539b7f 100644
--- a/src/copy.c
+++ b/src/copy.c
@@ -430,7 +430,8 @@ copy_reg (char const *src_name, char const *dst_name,
 	    {
 	      char *cp;
 
-	      buf[n_read] = 1;	/* Sentinel to stop loop.  */
+	      wp = (word *) (buf + n_read);
+	      *wp = 1;	/* Sentinel to stop loop.  */
 
 	      /* Find first nonzero *word*, or the word with the sentinel.  */