From: Willy Tarreau <w@1wt.eu>
Date: Mon, 22 Mar 2021 15:17:37 +0000 (+0100)
Subject: CLEANUP: l7-retries: do not test the buffer before calling b_alloc()
X-Git-Tag: v2.4-dev14~65
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f499f50c8fc1a2eeaf590c38d28c864b617b2d36;p=thirdparty%2Fhaproxy.git

CLEANUP: l7-retries: do not test the buffer before calling b_alloc()

The return value is enough now to know if the allocation succeeded or
failed.
---

diff --git a/src/http_ana.c b/src/http_ana.c
index c53f0a617f..82b389a5dd 100644
--- a/src/http_ana.c
+++ b/src/http_ana.c
@@ -1135,9 +1135,7 @@ int http_request_forward_body(struct stream *s, struct channel *req, int an_bit)
 			 */
 			DBG_TRACE_STATE("enable L7 retry, save the request", STRM_EV_STRM_ANA|STRM_EV_HTTP_ANA, s, txn);
 			si->flags |= SI_FL_L7_RETRY;
-			if (b_is_null(&si->l7_buffer))
-				b_alloc(&si->l7_buffer);
-			if (b_is_null(&si->l7_buffer))
+			if (b_alloc(&si->l7_buffer) == NULL)
 				si->flags &= ~SI_FL_L7_RETRY;
 			else {
 				memcpy(b_orig(&si->l7_buffer), b_orig(&req->buf), b_size(&req->buf));