From: Simon Green Date: Thu, 25 Jul 2013 04:28:54 +0000 (+1000) Subject: Bug 880113 - Use the cache for the product and component name X-Git-Tag: bugzilla-4.5.1~117 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f4e0626fd893031cf709f37e0fe2d4ee6a18afc8;p=thirdparty%2Fbugzilla.git Bug 880113 - Use the cache for the product and component name r=LpSolit, a=glob --- diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index 40acca8718..f27baa532d 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -3288,11 +3288,8 @@ sub cc_users { sub component { my ($self) = @_; - return $self->{component} if exists $self->{component}; return '' if $self->{error}; - ($self->{component}) = Bugzilla->dbh->selectrow_array( - 'SELECT name FROM components WHERE id = ?', - undef, $self->{component_id}); + $self->{component} //= $self->component_obj->name; return $self->{component}; } @@ -3492,11 +3489,8 @@ sub percentage_complete { sub product { my ($self) = @_; - return $self->{product} if exists $self->{product}; return '' if $self->{error}; - ($self->{product}) = Bugzilla->dbh->selectrow_array( - 'SELECT name FROM products WHERE id = ?', - undef, $self->{product_id}); + $self->{product} //= $self->product_obj->name; return $self->{product}; }