From: bbaetz%acm.org <>
Date: Mon, 29 Jun 2009 09:10:21 +0000 (+0000)
Subject: Bug 499103 - page_requires_login check uses undefined variable
X-Git-Tag: bugzilla-3.4rc1~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f4f5c0d415738e26a6706906e6c07d45c698033f;p=thirdparty%2Fbugzilla.git

Bug 499103 - page_requires_login check uses undefined variable
r/a=mkanat
---

diff --git a/Bugzilla.pm b/Bugzilla.pm
index 9ce6232236..7d1b1f801d 100644
--- a/Bugzilla.pm
+++ b/Bugzilla.pm
@@ -240,15 +240,16 @@ sub login {
     my $authorizer = new Bugzilla::Auth();
     $type = LOGIN_REQUIRED if $class->cgi->param('GoAheadAndLogIn');
 
+    if (!defined $type || $type == LOGIN_NORMAL) {
+        $type = $class->params->{'requirelogin'} ? LOGIN_REQUIRED : LOGIN_NORMAL;
+    }
+
     # Allow templates to know that we're in a page that always requires
     # login.
     if ($type == LOGIN_REQUIRED) {
         $class->request_cache->{page_requires_login} = 1;
     }
 
-    if (!defined $type || $type == LOGIN_NORMAL) {
-        $type = $class->params->{'requirelogin'} ? LOGIN_REQUIRED : LOGIN_NORMAL;
-    }
     my $authenticated_user = $authorizer->login($type);
     
     # At this point, we now know if a real person is logged in.