From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 29 Aug 2017 05:24:35 +0000 (+0200)
Subject: HEIMDAL:kdc: fix dh->q allocation check in get_dh_param()
X-Git-Tag: samba-4.6.13~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f502340923f089f9ac4fa060dc21471b59c29c56;p=thirdparty%2Fsamba.git

HEIMDAL:kdc: fix dh->q allocation check in get_dh_param()

Thanks to Doug Nazar <nazard@nazar.ca> for spotting this!

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12986

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from heimdal commit a79b59ba27070a015479e8d981b7e685dbe34310)
Reviewed-by: Andreas Schneider <asn@samba.org>

(cherry picked from commit 183e5d1e3dc306491c06f94c8c98e4882c64bc27)

Autobuild-User(v4-6-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-6-test): Sun Dec 24 01:15:07 CET 2017 on sn-devel-144
---

diff --git a/source4/heimdal/kdc/pkinit.c b/source4/heimdal/kdc/pkinit.c
index c874847cffd..ad7f3efc10a 100644
--- a/source4/heimdal/kdc/pkinit.c
+++ b/source4/heimdal/kdc/pkinit.c
@@ -384,7 +384,7 @@ get_dh_param(krb5_context context,
 
     if (dhparam.q) {
 	dh->q = integer_to_BN(context, "DH p-1 factor", dhparam.q);
-	if (dh->g == NULL)
+	if (dh->q == NULL)
 	    goto out;
     }