From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Wed, 12 Oct 2022 00:56:55 +0000 (+1300)
Subject: s4:gensec Avoid memory leak in error case in gensec_gssapi
X-Git-Tag: talloc-2.4.0~676
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f50e0c3cb4369ca564479a60314cfe27cd2ec6cd;p=thirdparty%2Fsamba.git

s4:gensec Avoid memory leak in error case in gensec_gssapi

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/source4/auth/gensec/gensec_gssapi.c b/source4/auth/gensec/gensec_gssapi.c
index e33c78462e2..cca19646dfc 100644
--- a/source4/auth/gensec/gensec_gssapi.c
+++ b/source4/auth/gensec/gensec_gssapi.c
@@ -836,6 +836,7 @@ init_sec_context_done:
 			}
 			
 			if (output_token.length < 4) {
+				gss_release_buffer(&min_stat, &output_token);
 				return NT_STATUS_INVALID_PARAMETER;
 			}
 
@@ -989,6 +990,7 @@ init_sec_context_done:
 		}
 			
 		if (output_token.length < 4) {
+			gss_release_buffer(&min_stat, &output_token);
 			return NT_STATUS_INVALID_PARAMETER;
 		}