From: Jeremy Allison <jra@samba.org>
Date: Mon, 2 Nov 2020 23:46:51 +0000 (-0800)
Subject: s3: modules: vfs_glusterfs: Fix leak of char **lines onto mem_ctx on return.
X-Git-Tag: samba-4.11.16~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f5135703e5f773a57369820cf667cf046741f322;p=thirdparty%2Fsamba.git

s3: modules: vfs_glusterfs: Fix leak of char **lines onto mem_ctx on return.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14486

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Nov  3 01:56:59 UTC 2020 on sn-devel-184

(cherry picked from commit 7d846cd178d653600c71ee4bd6a491a9e48a56da)

Autobuild-User(v4-11-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-11-test): Tue Nov  3 11:30:48 UTC 2020 on sn-devel-184
---

diff --git a/source3/modules/vfs_glusterfs.c b/source3/modules/vfs_glusterfs.c
index 8bbcee62969..747176ecebb 100644
--- a/source3/modules/vfs_glusterfs.c
+++ b/source3/modules/vfs_glusterfs.c
@@ -338,11 +338,13 @@ static int check_for_write_behind_translator(TALLOC_CTX *mem_ctx,
 			"Please check the vfs_glusterfs(8) manpage for "
 			"further details.\n",
 			volume);
+		TALLOC_FREE(lines);
 		TALLOC_FREE(option);
 		TALLOC_FREE(buf);
 		return -1;
 	}
 
+	TALLOC_FREE(lines);
 	TALLOC_FREE(option);
 	TALLOC_FREE(buf);
 	return 0;