From: Ben Darnell <ben@bendarnell.com>
Date: Wed, 20 May 2015 01:46:21 +0000 (-0400)
Subject: Disable twisted's test_process on python 3.
X-Git-Tag: v4.2.0~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f5380632c2c6c357eb5ec62e5ae3f416f56ba9f7;p=thirdparty%2Ftornado.git

Disable twisted's test_process on python 3.

The new twisted 15.2.0 has some failures in this test that appear to be
interactions between the two package's test suites rather than a problem
in the integration itself, so just disable the tests for now.
---

diff --git a/tornado/test/twisted_test.py b/tornado/test/twisted_test.py
index 8ace993d3..22410567a 100644
--- a/tornado/test/twisted_test.py
+++ b/tornado/test/twisted_test.py
@@ -593,6 +593,14 @@ if have_twisted:
         ],
         'twisted.internet.test.test_unix.UNIXPortTestsBuilder': [],
     }
+    if sys.version_info >= (3,):
+        # In Twisted 15.2.0 on Python 3.4, the process tests will try to run
+        # but fail, due in part to interactions between Tornado's strict
+        # warnings-as-errors policy and Twisted's own warning handling
+        # (it was not obvious how to configure the warnings module to
+        # reconcile the two), and partly due to what looks like a packaging
+        # error (process_cli.py missing). For now, just skip it.
+        del twisted_tests['twisted.internet.test.test_process.ProcessTestsBuilder']
     for test_name, blacklist in twisted_tests.items():
         try:
             test_class = import_object(test_name)