From: Matt Coleman <mcoleman@datto.com>
Date: Fri, 6 Nov 2020 03:32:43 +0000 (-0500)
Subject: domain_conf: make virDomainGraphicsDefParseXMLEGLHeadless() void
X-Git-Tag: v6.10.0-rc1~250
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f54661e0a220a51dbc44cb8e40cbd7e59452eb22;p=thirdparty%2Flibvirt.git

domain_conf: make virDomainGraphicsDefParseXMLEGLHeadless() void

This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0233fd7607..bb65b6d097 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -14883,7 +14883,7 @@ virDomainGraphicsDefParseXMLSpice(virDomainGraphicsDefPtr def,
 }
 
 
-static int
+static void
 virDomainGraphicsDefParseXMLEGLHeadless(virDomainGraphicsDefPtr def,
                                         xmlNodePtr node,
                                         xmlXPathContextPtr ctxt)
@@ -14896,7 +14896,6 @@ virDomainGraphicsDefParseXMLEGLHeadless(virDomainGraphicsDefPtr def,
     if ((glNode = virXPathNode("./gl", ctxt)))
         def->data.egl_headless.rendernode = virXMLPropString(glNode,
                                                              "rendernode");
-    return 0;
 }
 
 
@@ -14984,8 +14983,7 @@ virDomainGraphicsDefParseXML(virDomainXMLOptionPtr xmlopt,
             goto error;
         break;
     case VIR_DOMAIN_GRAPHICS_TYPE_EGL_HEADLESS:
-        if (virDomainGraphicsDefParseXMLEGLHeadless(def, node, ctxt) < 0)
-            goto error;
+        virDomainGraphicsDefParseXMLEGLHeadless(def, node, ctxt);
         break;
     case VIR_DOMAIN_GRAPHICS_TYPE_LAST:
         break;