From: Jes Sorensen <Jes.Sorensen@redhat.com>
Date: Wed, 2 Nov 2011 21:08:00 +0000 (+1100)
Subject: array_try_spare(): open_dev() returns -1 on error, not zero
X-Git-Tag: mdadm-3.2.3~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f56128b9bc8e080ea576b0c1cbf0cb40cfc0b657;p=thirdparty%2Fmdadm.git

array_try_spare(): open_dev() returns -1 on error, not zero

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/Incremental.c b/Incremental.c
index c2c90519..d3724a48 100644
--- a/Incremental.c
+++ b/Incremental.c
@@ -884,7 +884,7 @@ static int array_try_spare(char *devname, int *dfdp, struct dev_policy *pol,
 			 * to obtain minimum spare size */
 			struct supertype *st3 = dup_super(st2);
 			int mdfd = open_dev(mp->devnum);
-			if (!mdfd) {
+			if (mdfd < 0) {
 				free(st3);
 				goto next;
 			}