From: Volker Lendecke <vl@samba.org>
Date: Sun, 5 Sep 2021 06:59:13 +0000 (+0200)
Subject: auth: Simplify is_our_machine_account()
X-Git-Tag: ldb-2.5.0~768
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f585f01148ab2d8f84c96b12e018742f5f17bcb0;p=thirdparty%2Fsamba.git

auth: Simplify is_our_machine_account()

Use strnequal instead of duplicating a string

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/auth/server_info_sam.c b/source3/auth/server_info_sam.c
index 79a7af7281e..b9c8b0a0959 100644
--- a/source3/auth/server_info_sam.c
+++ b/source3/auth/server_info_sam.c
@@ -38,19 +38,12 @@
 static bool is_our_machine_account(const char *username)
 {
 	bool ret;
-	char *truncname = NULL;
 	size_t ulen = strlen(username);
 
 	if (ulen == 0 || username[ulen-1] != '$') {
 		return false;
 	}
-	truncname = SMB_STRDUP(username);
-	if (!truncname) {
-		return false;
-	}
-	truncname[ulen-1] = '\0';
-	ret = strequal(truncname, lp_netbios_name());
-	SAFE_FREE(truncname);
+	ret = strnequal(username, lp_netbios_name(), ulen-1);
 	return ret;
 }