From: Ben Kaduk <kaduk@mit.edu>
Date: Wed, 27 Jun 2012 19:38:47 +0000 (-0400)
Subject: Avoid unsigned/signed comparison in loop condition
X-Git-Tag: krb5-1.11-alpha1~462
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f59478241686d75ece48e8eff6099006cf0bb1b2;p=thirdparty%2Fkrb5.git

Avoid unsigned/signed comparison in loop condition

The gid_len length is declared as an unsigned int, and loop
index 'i' is a signed int.  This could manifest as an infinite
loop if gid_len is very large.  In practice, gid_len should be small,
but make 'i' the same type for consistency.
---

diff --git a/src/lib/rpc/svc_auth_unix.c b/src/lib/rpc/svc_auth_unix.c
index 406abf7eb8..a4b87d8ff4 100644
--- a/src/lib/rpc/svc_auth_unix.c
+++ b/src/lib/rpc/svc_auth_unix.c
@@ -66,8 +66,7 @@ gssrpc__svcauth_unix(
 		char area_machname[MAX_MACHINE_NAME+1];
 		int area_gids[NGRPS];
 	} *area;
-	u_int auth_len, str_len, gid_len;
-	register int i;
+	u_int auth_len, str_len, gid_len, i;
 
 	rqst->rq_xprt->xp_auth = &svc_auth_none;