From: Richard Mudgett <rmudgett@digium.com>
Date: Mon, 23 Nov 2015 20:27:27 +0000 (-0600)
Subject: res_sorcery_realtime.c: Fix crash from NULL sorcery object type.
X-Git-Tag: certified/13.1-cert3~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f5a60607077a7a2fca46fb2ef91f59cc75f7a132;p=thirdparty%2Fasterisk.git

res_sorcery_realtime.c: Fix crash from NULL sorcery object type.

If the sorcery object type is not found a NULL is returned.
Unfortunately, sorcery_realtime_filter_objectset() will crash after
complaining about not finding the object type and saying to expect errors.

* Use ao2_cleanup() instead of ao2_ref() to prevent the crash.

ASTERISK-25165
Reported by Corey Farrell

Change-Id: Ic3b64453ea3058cb68d5c26d97d4fe7b8eea2e97
---

diff --git a/res/res_sorcery_realtime.c b/res/res_sorcery_realtime.c
index 61a97c6dd8..9724fb26f4 100644
--- a/res/res_sorcery_realtime.c
+++ b/res/res_sorcery_realtime.c
@@ -142,7 +142,7 @@ static struct ast_variable *sorcery_realtime_filter_objectset(struct ast_variabl
 		}
 	}
 
-	ao2_ref(object_type, -1);
+	ao2_cleanup(object_type);
 
 	return objectset;
 }