From: harry <harmanmanchanda182@gmail.com>
Date: Fri, 3 Mar 2017 19:21:46 +0000 (+0530)
Subject: Hollow button disabled consistency fix #9832
X-Git-Tag: v6.4.0-rc1~87^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f5aba1589facef5167d14d295b6e084a1ec13821;p=thirdparty%2Ffoundation%2Ffoundation-sites.git

Hollow button disabled consistency fix #9832
---

diff --git a/docs/pages/button.md b/docs/pages/button.md
index 1b7318adf..39cd969fa 100644
--- a/docs/pages/button.md
+++ b/docs/pages/button.md
@@ -108,9 +108,9 @@ The `.disabled` class will give buttons a faded appearance. The class is a purel
 
 ```html_example
 <a class="button disabled" href="#" aria-disabled>Disabled</a>
-<button type="button" class="button primary" disabled>Disabled</button>
+<button type="button" class="button primary hollow" disabled>Disabled</button>
 <button type="button" class="button secondary" disabled>Disabled</button>
-<button type="button" class="button success" disabled>Disabled</button>
+<button type="button" class="button success hollow" disabled>Disabled</button>
 <button type="button" class="button alert" disabled>Disabled</button>
 <button type="button" class="button warning" disabled>Disabled</button>
 ```
diff --git a/scss/components/_button.scss b/scss/components/_button.scss
index 26170a3ae..5b9209cf6 100644
--- a/scss/components/_button.scss
+++ b/scss/components/_button.scss
@@ -169,6 +169,11 @@ $button-transition: background-color 0.25s ease-out, color 0.25s ease-out !defau
   &:hover, &:focus {
     border-color: $color-hover;
     color: $color-hover;
+    &.disabled,
+    &[disabled] {
+      border: $border-width solid $color;
+      color: $color;
+    }
   }
 }
 
@@ -271,12 +276,31 @@ $button-transition: background-color 0.25s ease-out, color 0.25s ease-out !defau
       }
     }
 
+    // Disabled style
+    &.disabled,
+    &[disabled] {
+      @include button-disabled;
+
+      @each $name, $color in $button-palette {
+        &.#{$name} {
+          @include button-disabled($color, auto);
+        }
+      }
+    }
+
     // Hollow style
     @if $button-fill != hollow {
       &.hollow {
         @include button-hollow;
         @include button-hollow-style;
 
+        &.disabled,
+        &[disabled] {
+          &, &:hover, &:focus {
+            background-color: transparent;
+          }
+        }
+
         @each $name, $color in $button-palette {
           &.#{$name} {
             @include button-hollow-style($color);
@@ -285,18 +309,6 @@ $button-transition: background-color 0.25s ease-out, color 0.25s ease-out !defau
       }
     }
 
-    // Disabled style
-    &.disabled,
-    &[disabled] {
-      @include button-disabled;
-
-      @each $name, $color in $button-palette {
-        &.#{$name} {
-          @include button-disabled($color, auto);
-        }
-      }
-    }
-
     // Dropdown arrow
     &.dropdown {
       @include button-dropdown;