From: Frédéric Buclin <LpSolit@gmail.com>
Date: Thu, 22 Apr 2010 18:16:44 +0000 (+0200)
Subject: Bug 561129: Various warnings thrown by Search.pm: Perl 5.12 complains for lc(undef... 
X-Git-Tag: bugzilla-3.6.1~22
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f5ad1f25c35905013dc6997611cc87d497780267;p=thirdparty%2Fbugzilla.git

Bug 561129: Various warnings thrown by Search.pm: Perl 5.12 complains for lc(undef) and uc(undef)
r/a=mkanat
---

diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm
index 630cdd7d5a..d9f1d20397 100644
--- a/Bugzilla/Search.pm
+++ b/Bugzilla/Search.pm
@@ -388,8 +388,8 @@ sub init {
         }
     }
 
-    my $chfieldfrom = trim(lc($params->param('chfieldfrom'))) || '';
-    my $chfieldto = trim(lc($params->param('chfieldto'))) || '';
+    my $chfieldfrom = trim(lc($params->param('chfieldfrom') || ''));
+    my $chfieldto = trim(lc($params->param('chfieldto') || ''));
     $chfieldfrom = '' if ($chfieldfrom eq 'now');
     $chfieldto = '' if ($chfieldto eq 'now');
     my @chfield = $params->param('chfield');
@@ -1181,8 +1181,7 @@ sub BuildOrderBy {
 sub split_order_term {
     my $fragment = shift;
     $fragment =~ /^(.+?)(?:\s+(ASC|DESC))?$/i;
-    my ($column_name, $direction) = (lc($1), uc($2));
-    $direction ||= "";
+    my ($column_name, $direction) = (lc($1), uc($2 || ''));
     return wantarray ? ($column_name, $direction) : $column_name;
 }