From: Pavel Hrdina <phrdina@redhat.com>
Date: Wed, 2 Nov 2022 14:30:46 +0000 (+0100)
Subject: qemu_snapshot: error out when deleting internal snapshot on non-active disk
X-Git-Tag: v9.0.0-rc1~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f5def5cd11683c62d7746c16f3bc3c3bab60d724;p=thirdparty%2Flibvirt.git

qemu_snapshot: error out when deleting internal snapshot on non-active disk

Deleting internal snapshot when the currently active disk image is
different than where the internal snapshot was taken doesn't work
correctly.

This applies to a running VM only as we are using QMP command and
talking to the QEMU process that is using different disk.

This works correctly when the VM is shut of as in this case we spawn
qemu-img process to delete the snapshot.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index c23f629e9f..30137a2b8f 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
@@ -2492,9 +2492,31 @@ qemuSnapshotCountExternalInternal(void *payload,
 
 
 static int
-qemuSnapshotDeleteValidate(virDomainMomentObj *snap,
+qemuSnapshotDeleteValidate(virDomainObj *vm,
+                           virDomainMomentObj *snap,
                            unsigned int flags)
 {
+    if (!virDomainSnapshotIsExternal(snap) &&
+        virDomainObjIsActive(vm)) {
+        ssize_t i;
+        virDomainSnapshotDef *snapdef = virDomainSnapshotObjGetDef(snap);
+
+        for (i = 0; i < snapdef->ndisks; i++) {
+            virDomainSnapshotDiskDef *snapDisk = &(snapdef->disks[i]);
+            virDomainDiskDef *vmdisk = NULL;
+            virDomainDiskDef *disk = NULL;
+
+            vmdisk = qemuDomainDiskByName(vm->def, snapDisk->name);
+            disk = qemuDomainDiskByName(snapdef->parent.dom, snapDisk->name);
+
+            if (!virStorageSourceIsSameLocation(vmdisk->src, disk->src)) {
+                virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
+                               _("disk image '%s' for internal snapshot '%s' is not the same as disk image currently used by VM"),
+                               snapDisk->name, snap->def->name);
+                return -1;
+            }
+        }
+    }
 
     if (flags & (VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN |
                  VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY)) {
@@ -2548,7 +2570,7 @@ qemuSnapshotDelete(virDomainObj *vm,
         goto endjob;
 
     if (!metadata_only) {
-        if (qemuSnapshotDeleteValidate(snap, flags) < 0)
+        if (qemuSnapshotDeleteValidate(vm, snap, flags) < 0)
             goto endjob;
     }