From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 6 May 2021 12:00:16 +0000 (+0200)
Subject: virXMLPropUInt: Always initialize @result
X-Git-Tag: v7.4.0-rc1~195
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f5eb6d0ad9e8a7a9ac8262c40933a4821312e632;p=thirdparty%2Flibvirt.git

virXMLPropUInt: Always initialize @result

Compilers aren't able to see whether @result is set or not and thus
don't warn of a potential use of uninitialized value. Always set @result
to prevent uninitialized use.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/util/virxml.c b/src/util/virxml.c
index 707a6a2235..a03cbf7265 100644
--- a/src/util/virxml.c
+++ b/src/util/virxml.c
@@ -706,6 +706,7 @@ virXMLPropInt(xmlNodePtr node,
  * @result: The returned value
  *
  * Convenience function to return value of an unsigned integer attribute.
+ * @result is initialized to 0 on error or if the element is not found.
  *
  * Returns 1 in case of success in which case @result is set,
  *         or 0 if the attribute is not present,
@@ -722,6 +723,8 @@ virXMLPropUInt(xmlNodePtr node,
     int ret;
     unsigned int val;
 
+    *result = 0;
+
     if (!(tmp = virXMLPropString(node, name))) {
         if (!(flags & VIR_XML_PROP_REQUIRED))
             return 0;