From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 8 Jun 2020 08:49:36 +0000 (+0200)
Subject: virSysinfoReadDMI: Drop needless virFindFileInPath()
X-Git-Tag: v6.5.0-rc1~219
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f603b99ad9becae453c2e9056a8bf1e082c7f68b;p=thirdparty%2Flibvirt.git

virSysinfoReadDMI: Drop needless virFindFileInPath()

When trying to decode DMI table, just before constructing
virCommand() the decoder is looked for in PATH using
virFindFileInPath(). Well, this is not necessary because
virCommandRun() will do this too (in virExec()).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c
index 296a2e2cc1..0f1210ab37 100644
--- a/src/util/virsysinfo.c
+++ b/src/util/virsysinfo.c
@@ -1119,20 +1119,12 @@ virSysinfoParseX86Memory(const char *base, virSysinfoDefPtr ret)
 virSysinfoDefPtr
 virSysinfoReadDMI(void)
 {
-    g_autofree char *path = NULL;
     g_auto(virSysinfoDefPtr) ret = NULL;
     g_autofree char *outbuf = NULL;
     g_autoptr(virCommand) cmd = NULL;
 
-    path = virFindFileInPath(SYSINFO_SMBIOS_DECODER);
-    if (path == NULL) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("Failed to find path for %s binary"),
-                       SYSINFO_SMBIOS_DECODER);
-        return NULL;
-    }
-
-    cmd = virCommandNewArgList(path, "-q", "-t", "0,1,2,3,4,17", NULL);
+    cmd = virCommandNewArgList(SYSINFO_SMBIOS_DECODER,
+                               "-q", "-t", "0,1,2,3,4,17", NULL);
     virCommandSetOutputBuffer(cmd, &outbuf);
     if (virCommandRun(cmd, NULL) < 0)
         return NULL;