From: Jim Meyering <jim@meyering.net>
Date: Fri, 19 Apr 1996 05:07:52 +0000 (+0000)
Subject: (copy_reg): Rearrange arithmetic in conditional to avoid
X-Git-Tag: TEXTUTILS-1_14b~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f60c8ea48bf9e61e7443c1f4c07c630d93746f83;p=thirdparty%2Fcoreutils.git

(copy_reg): Rearrange arithmetic in conditional to avoid
integer overflow with large files.
---

diff --git a/src/cp.c b/src/cp.c
index a44046abed..837d5fb107 100644
--- a/src/cp.c
+++ b/src/cp.c
@@ -1242,7 +1242,7 @@ copy_reg (char *src_path, char *dst_path)
 	 be needed for a file of its size, then
 	 at least one of the blocks in the file is a hole. */
       /* FIXME: isn't there risk of overflow here?  */
-      if (S_ISREG (sb.st_mode) && sb.st_size > ST_NBLOCKS (sb) * 512)
+      if (S_ISREG (sb.st_mode) && sb.st_size / 512 > ST_NBLOCKS (sb))
 	make_holes = 1;
     }
 #endif