From: Anthony Minessale <anthm@freeswitch.org>
Date: Wed, 2 Feb 2011 22:22:43 +0000 (-0600)
Subject: fix possible bad pointer in global vars (please test)
X-Git-Tag: v1.2-rc1~187^2~23^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f60fdf653dd2d7f8d3eaa6a9086e1f68bd993c59;p=thirdparty%2Ffreeswitch.git

fix possible bad pointer in global vars (please test)
---

diff --git a/fscomm/widgets/codecwidget.cpp b/fscomm/widgets/codecwidget.cpp
index 42b10febfd..2f82e1a8cc 100644
--- a/fscomm/widgets/codecwidget.cpp
+++ b/fscomm/widgets/codecwidget.cpp
@@ -131,6 +131,8 @@ void CodecWidget::setCodecString(QString codecList)
         QStringList parsed = codecList.split("{");
         QString var = parsed.at(1);
         var = var.split("}").at(0);
+		// warning switch_core_get_Variable may return an unsafe pointer in some cases.
+		// revise to use switch_core_get_variable_dup, and then free it after you are done.
         var = switch_core_get_variable(var.toAscii().data());
         if ( ! var.isEmpty() ) {
             codecList = var;