From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Sun, 24 Oct 2021 02:18:05 +0000 (+1300)
Subject: CVE-2020-25722 pytest: assertRaisesLdbError invents a message if you're lazy
X-Git-Tag: samba-4.13.14~128
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f64fe0b1e749814c76789c58e23e0fb0ef504617;p=thirdparty%2Fsamba.git

CVE-2020-25722 pytest: assertRaisesLdbError invents a message if you're lazy

This makes it easier to convert tests that don't have good messages.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14564

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/tests/__init__.py b/python/samba/tests/__init__.py
index 388036939cd..e04ddcb4ba8 100644
--- a/python/samba/tests/__init__.py
+++ b/python/samba/tests/__init__.py
@@ -317,6 +317,8 @@ class TestCase(unittest.TestCase):
 
     def assertRaisesLdbError(self, errcode, message, f, *args, **kwargs):
         """Assert a function raises a particular LdbError."""
+        if message is None:
+            message = f"{f.__name__}(*{args}, **{kwargs})"
         try:
             f(*args, **kwargs)
         except ldb.LdbError as e: