From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 24 Mar 2010 20:03:42 +0000 (+0100)
Subject: config: pass struct as const call-by-ref instead of call-by-value, to minimize copying
X-Git-Tag: v0.36~25
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f656d40493247a9d51f712ae9d3edbcc653a1c1d;p=thirdparty%2Flibcgroup.git

config: pass struct as const call-by-ref instead of call-by-value, to minimize copying

Signed-off-by: Lennart Poettering <lennart@poettering.net>
Acked-by: Dhaval Giani <dhaval.giani@gmail.com>
Signed-off-by: Dhaval Giani <dhaval.giani@gmail.com>
---

diff --git a/src/config.c b/src/config.c
index dfee471b..b6be503b 100644
--- a/src/config.c
+++ b/src/config.c
@@ -719,7 +719,7 @@ err_mnt:
 	return error;
 }
 
-static int cgroup_config_unload_controller(struct cgroup_mount_point mount_info)
+static int cgroup_config_unload_controller(const struct cgroup_mount_point *mount_info)
 {
 	int ret, error;
 	struct cgroup *cgroup = NULL;
@@ -729,7 +729,7 @@ static int cgroup_config_unload_controller(struct cgroup_mount_point mount_info)
 	if (cgroup == NULL)
 		return ECGFAIL;
 
-	cgc = cgroup_add_controller(cgroup, mount_info.name);
+	cgc = cgroup_add_controller(cgroup, mount_info->name);
 	if (cgc == NULL) {
 		ret = ECGFAIL;
 		goto out_error;
@@ -739,14 +739,14 @@ static int cgroup_config_unload_controller(struct cgroup_mount_point mount_info)
 	if (ret != 0)
 		goto out_error;
 
-	error = umount(mount_info.path);
+	error = umount(mount_info->path);
 	if (error) {
 		last_errno = errno;
 		ret = ECGOTHER;
 		goto out_error;
 	}
 
-	error = rmdir(mount_info.path);
+	error = rmdir(mount_info->path);
 	if (error) {
 		last_errno = errno;
 		ret = ECGOTHER;
@@ -790,7 +790,7 @@ int cgroup_unload_cgroups(void)
 			if (!curr_path)
 				goto out_errno;
 
-			ret = cgroup_config_unload_controller(info);
+			ret = cgroup_config_unload_controller(&info);
 
 			if (ret)
 				goto out_error;