From: Andrey Volk <andywolk@gmail.com>
Date: Wed, 20 Nov 2019 07:38:27 +0000 (+0400)
Subject: [fs_cli] Fix unchecked tainted data.
X-Git-Tag: v1.10.2^2~22
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f664600df47e4eae9d8e93011d7f695cdc2f5162;p=thirdparty%2Ffreeswitch.git

[fs_cli] Fix unchecked tainted data.
---

diff --git a/libs/esl/fs_cli.c b/libs/esl/fs_cli.c
index fd6153e091..b63fdd845a 100644
--- a/libs/esl/fs_cli.c
+++ b/libs/esl/fs_cli.c
@@ -1002,10 +1002,13 @@ static const char *basic_gets(int *cnt)
 	for (x = 0; x < (sizeof(command_buf) - 1); x++) {
 		int c = getchar();
 		if (c < 0) {
+			size_t command_buf_len;
 			if (fgets(command_buf, sizeof(command_buf) - 1, stdin) != command_buf) {
 				break;
+			}			
+			if ((command_buf_len = strlen(command_buf)) > 0) {
+				command_buf[command_buf_len - 1] = '\0'; /* remove endline */
 			}
-			command_buf[strlen(command_buf)-1] = '\0'; /* remove endline */
 			break;
 		}
 		command_buf[x] = (char) c;