From: Charlie Brej <cbrej@cs.man.ac.uk>
Date: Mon, 22 Jun 2009 15:37:58 +0000 (+0100)
Subject: [script] Dereference on assign without affecting refcount
X-Git-Tag: 0.7.0~153
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f66f6078c1fc8d4fa051c87011c01255ce47309a;p=thirdparty%2Fplymouth.git

[script] Dereference on assign without affecting refcount

Assigns were incorrectly dereferencing creating an incorrect refcount.
---

diff --git a/src/plugins/splash/script/script-object.c b/src/plugins/splash/script/script-object.c
index 4e017cf5..5a56d5e8 100644
--- a/src/plugins/splash/script/script-object.c
+++ b/src/plugins/splash/script/script-object.c
@@ -349,8 +349,8 @@ char* script_obj_as_string (script_obj* obj)              // reply is strdupped
 
 void script_obj_assign (script_obj* obj_a, script_obj* obj_b)
 {
- script_obj_deref (&obj_b);
  script_obj_reset (obj_a);
+ obj_b = script_obj_deref_direct (obj_b);
  
  switch (obj_b->type){
     case SCRIPT_OBJ_TYPE_NULL: