From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Thu, 12 Jan 2023 09:36:26 +0000 (+0100)
Subject: MINOR: quic: Useless test about datagram destination addresses
X-Git-Tag: v2.8-dev2~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f676954f72669a442999c8499df82da08a027f9b;p=thirdparty%2Fhaproxy.git

MINOR: quic: Useless test about datagram destination addresses

There is no reason to check if the peer has modified the destination
address of its connection.

May be backported to 2.7.
---

diff --git a/src/quic_conn.c b/src/quic_conn.c
index e3a8b46346..72b8439cd4 100644
--- a/src/quic_conn.c
+++ b/src/quic_conn.c
@@ -7406,8 +7406,7 @@ int quic_dgram_parse(struct quic_dgram *dgram, struct quic_conn *from_qc,
 		}
 
 		/* Detect QUIC connection migration. */
-		if (ipcmp(&qc->peer_addr, &dgram->saddr, 1) ||
-		    ipcmp(&qc->local_addr, &dgram->daddr, 1)) {
+		if (ipcmp(&qc->peer_addr, &dgram->saddr, 1)) {
 			if (qc_handle_conn_migration(qc, &dgram->saddr, &dgram->daddr)) {
 				/* Skip the entire datagram. */
 				TRACE_ERROR("error during connection migration, datagram dropped", QUIC_EV_CONN_LPKT, qc);