From: Tom Hughes <tom@compton.nu>
Date: Wed, 20 Jul 2005 13:49:55 +0000 (+0000)
Subject: Document different argument order for clone on amd64.
X-Git-Tag: svn/VALGRIND_3_0_0~101
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f67d1dc95ea1dded101594511b8361999b7532eb;p=thirdparty%2Fvalgrind.git

Document different argument order for clone on amd64.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@4217
---

diff --git a/coregrind/m_syswrap/syswrap-amd64-linux.c b/coregrind/m_syswrap/syswrap-amd64-linux.c
index 2aa9583d56..8f115e9b03 100644
--- a/coregrind/m_syswrap/syswrap-amd64-linux.c
+++ b/coregrind/m_syswrap/syswrap-amd64-linux.c
@@ -496,7 +496,9 @@ static SysRes do_fork_clone ( ThreadId tid,
    VG_(sigprocmask)(VKI_SIG_SETMASK, &mask, &fork_saved_mask);
 
    /* Since this is the fork() form of clone, we don't need all that
-      VG_(clone) stuff */
+      VG_(clone) stuff - note that the last two arguments are the
+      opposite way round to x86 and ppc32 as the amd64 kernel expects
+      the arguments in a different order */
    res = VG_(do_syscall5)( __NR_clone, flags, 
                            (UWord)NULL, (UWord)parent_tidptr, 
                            (UWord)child_tidptr, (UWord)NULL );