From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Wed, 10 Mar 2021 09:13:48 +0000 (+1300)
Subject: util:str_sub: talloc_free on error
X-Git-Tag: tevent-0.11.0~1561
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f67f95f009a417aca2c636e4a6d17fa87325813e;p=thirdparty%2Fsamba.git

util:str_sub: talloc_free on error

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/lib/util/substitute.c b/lib/util/substitute.c
index 3ca53d912c4..b7b5588da86 100644
--- a/lib/util/substitute.c
+++ b/lib/util/substitute.c
@@ -194,6 +194,7 @@ char *talloc_string_sub2(TALLOC_CTX *mem_ctx, const char *src,
 	in = talloc_strdup(mem_ctx, insert);
 	if (!in) {
 		DEBUG(0, ("talloc_string_sub2: ENOMEM\n"));
+		talloc_free(string);
 		return NULL;
 	}
 	ls = (ssize_t)strlen(s);