From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Fri, 4 Feb 2022 18:19:34 +0000 (-0500)
Subject: Don't leave interface_id uninitialised
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f6a4a104d61539773c80727de63bcc7191b278fb;p=thirdparty%2Ffreeradius-server.git

Don't leave interface_id uninitialised
---

diff --git a/src/process/dhcpv6/base.c b/src/process/dhcpv6/base.c
index eae4266fa82..be83a985b5f 100644
--- a/src/process/dhcpv6/base.c
+++ b/src/process/dhcpv6/base.c
@@ -647,7 +647,7 @@ process_dhcpv6_relay_fields_t *dhcpv6_relay_fields_store(request_t *request)
 	/*
 	 *	Remember the relay fields
 	 */
-	MEM(rctx = talloc(unlang_interpret_frame_talloc_ctx(request), process_dhcpv6_relay_fields_t));
+	MEM(rctx = talloc_zero(unlang_interpret_frame_talloc_ctx(request), process_dhcpv6_relay_fields_t)); /* Safer to zero the whole thing */
 	MEM(rctx->hop_count = fr_pair_copy(rctx, hop_count));
 	MEM(rctx->link_address = fr_pair_copy(rctx, link_address));
 	MEM(rctx->peer_address = fr_pair_copy(rctx, peer_address));