From: Eric Wong <e@80x24.org>
Date: Mon, 24 Jun 2019 02:52:11 +0000 (+0000)
Subject: ds: remove support for DS->write(undef)
X-Git-Tag: v1.2.0~156^2~49
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f6c9b3da9cf87cfbde7b95772de6b337ba46ef68;p=thirdparty%2Fpublic-inbox.git

ds: remove support for DS->write(undef)

We call ->flush_write directly, now; so we can eliminate a
needless check.
---

diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm
index 8fc49eee6..ba8bd95f1 100644
--- a/lib/PublicInbox/DS.pm
+++ b/lib/PublicInbox/DS.pm
@@ -518,14 +518,13 @@ sub flush_write ($) {
 =head2 C<< $obj->write( $data ) >>
 
 Write the specified data to the underlying handle.  I<data> may be scalar,
-scalar ref, code ref (to run when there), or undef just to kick-start.
+scalar ref, code ref (to run when there).
 Returns 1 if writes all went through, or 0 if there are writes in queue. If
 it returns 1, caller should stop waiting for 'writable' events)
 
 =cut
 sub write {
     my ($self, $data) = @_;
-    return flush_write($self) unless defined $data;
 
     # nobody should be writing to closed sockets, but caller code can
     # do two writes within an event, have the first fail and