From: Andreas Schneider <asn@samba.org>
Date: Wed, 6 Mar 2024 14:59:14 +0000 (+0100)
Subject: s3:librpc: Use lp_dns_hostname() for creating the fqdn
X-Git-Tag: tdb-1.4.11~599
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f6efc74670d7a7daa1ebf50bf14dde5b75bc2d88;p=thirdparty%2Fsamba.git

s3:librpc: Use lp_dns_hostname() for creating the fqdn

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/librpc/crypto/gse_krb5.c b/source3/librpc/crypto/gse_krb5.c
index f1e0e5194bf..0ea3f5b09b8 100644
--- a/source3/librpc/crypto/gse_krb5.c
+++ b/source3/librpc/crypto/gse_krb5.c
@@ -354,15 +354,19 @@ static krb5_error_code fill_mem_keytab_from_system_keytab(krb5_context krbctx,
 	fstring my_name, my_fqdn;
 	unsigned i;
 	int err;
+	const char *dns_hostname = NULL;
 
 	/* Generate the list of principal names which we expect
 	 * clients might want to use for authenticating to the file
 	 * service.  We allow name$,{host,cifs}/{name,fqdn,name.REALM}. */
 
 	fstrcpy(my_name, lp_netbios_name());
-
-	my_fqdn[0] = '\0';
-	name_to_fqdn(my_fqdn, lp_netbios_name());
+	dns_hostname = lp_dns_hostname();
+	if (dns_hostname == NULL) {
+		ret = ENOMEM;
+		goto out;
+	}
+	fstrcpy(my_fqdn, dns_hostname);
 
 	err = asprintf(&valid_princ_formats[0],
 			"%s$@%s", my_name, lp_realm());