From: Ondřej Surý <ondrej@isc.org>
Date: Mon, 11 Aug 2025 14:22:03 +0000 (+0200)
Subject: Fix typo in nsupdate where covers would be equal to type
X-Git-Tag: v9.21.12~44^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f7143dca3f05c9b53eaa277a72cf6fd3fe50ba4f;p=thirdparty%2Fbind9.git

Fix typo in nsupdate where covers would be equal to type

There was an apparent typo where rdatalist->covers would be assigned the
same value as rdatalist->type.  As nsupdate can't update signatures, the
covers must be dns_rdatatype_none.
---

diff --git a/bin/nsupdate/nsupdate.c b/bin/nsupdate/nsupdate.c
index 24990effda4..8d03a49e444 100644
--- a/bin/nsupdate/nsupdate.c
+++ b/bin/nsupdate/nsupdate.c
@@ -2084,7 +2084,7 @@ doneparsing:
 	dns_message_gettemprdataset(updatemsg, &rdataset);
 	rdatalist->type = rdatatype;
 	rdatalist->rdclass = rdataclass;
-	rdatalist->covers = rdatatype;
+	rdatalist->covers = dns_rdatatype_none;
 	rdatalist->ttl = (dns_ttl_t)ttl;
 	ISC_LIST_APPEND(rdatalist->rdata, rdata, link);
 	dns_rdatalist_tordataset(rdatalist, rdataset);