From: Mark Andrews <marka@isc.org>
Date: Sun, 5 Aug 2018 05:23:07 +0000 (+0200)
Subject: Only get one random number per response when order == random
X-Git-Tag: v9.13.3~77^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f7986c8d1a35f8552b60e454403832dc776a9fc0;p=thirdparty%2Fbind9.git

Only get one random number per response when order == random
---

diff --git a/lib/dns/rdataset.c b/lib/dns/rdataset.c
index aad094ef494..afe76e16dd9 100644
--- a/lib/dns/rdataset.c
+++ b/lib/dns/rdataset.c
@@ -409,9 +409,8 @@ towiresorted(dns_rdataset_t *rdataset, const dns_name_t *owner_name,
 			/*
 			 * 'Random' order.
 			 */
+			isc_uint32_t val = isc_random32();
 			for (i = 0; i < count; i++) {
-				isc_uint32_t val = isc_random32();
-
 				choice = i + val % (count - i);
 				rdata = in[i];
 				in[i] = in[choice];