From: Otto Moerbeek Date: Fri, 4 Feb 2022 09:56:17 +0000 (+0100) Subject: Apply suggestions from code review X-Git-Tag: auth-4.7.0-alpha1~20^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f7c973de073a5cae0af462cb86285eedcc76fd01;p=thirdparty%2Fpdns.git Apply suggestions from code review Co-authored-by: Remi Gacogne --- diff --git a/pdns/lua-base4.cc b/pdns/lua-base4.cc index aea4146d85..31c2da0cf7 100644 --- a/pdns/lua-base4.cc +++ b/pdns/lua-base4.cc @@ -245,7 +245,7 @@ void BaseLua4::prepareContext() { {"NXRRSET", RCode::NXRRSet }, {"NOTAUTH", RCode::NotAuth }, {"NOTZONE", RCode::NotZone }, - {"DROP", -2 }}; // To give backport-incompatibilityy warning + {"DROP", -2 }}; // To give backport-incompatibility warning for(const auto& rcode : rcodes) d_pd.push_back({rcode.first, rcode.second}); diff --git a/pdns/lua-recursor4.cc b/pdns/lua-recursor4.cc index 6124c7328b..f9ad1032a3 100644 --- a/pdns/lua-recursor4.cc +++ b/pdns/lua-recursor4.cc @@ -500,7 +500,7 @@ void RecursorLua4::getFeatures(Features& features) static void warnDrop(const RecursorLua4::DNSQuestion& dq) { if (dq.rcode == -2) { - g_log << Logger::Error << "Returing -2 (pdns.DROP) is not supported anymore, see https://docs.powerdns.com/recursor/lua-scripting/hooks.html#hooksemantics" << endl; + g_log << Logger::Error << "Returning -2 (pdns.DROP) is not supported anymore, see https://docs.powerdns.com/recursor/lua-scripting/hooks.html#hooksemantics" << endl; // We *could* set policy here, but that would also mean interfering with rcode and the return code of the hook. // So leave it at the error message. }