From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Wed, 17 Jun 2015 17:27:29 +0000 (-0400)
Subject: tmpl_from_attr_substr ret = 0 also indicates an error
X-Git-Tag: release_3_0_9~93
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f7ef90ee126f8c6e39e232c60f40527a1a025178;p=thirdparty%2Ffreeradius-server.git

tmpl_from_attr_substr ret = 0 also indicates an error
---

diff --git a/src/modules/rlm_expr/rlm_expr.c b/src/modules/rlm_expr/rlm_expr.c
index bcaa3be038e..7b476b9a9f5 100644
--- a/src/modules/rlm_expr/rlm_expr.c
+++ b/src/modules/rlm_expr/rlm_expr.c
@@ -231,7 +231,7 @@ static bool get_number(REQUEST *request, char const **string, int64_t *answer)
 		p += 1;
 
 		slen = tmpl_from_attr_substr(&vpt, p, REQUEST_CURRENT, PAIR_LIST_REQUEST, false, false);
-		if (slen < 0) {
+		if (slen <= 0) {
 			REDEBUG("Failed parsing attribute name '%s': %s", p, fr_strerror());
 			return false;
 		}