From: Tom Hromatka Date: Tue, 27 Apr 2021 16:35:46 +0000 (+0000) Subject: api.c: Fix strncpy() truncation warning X-Git-Tag: v2.0~2^2~13 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f7f698c2993b8ce053a2b919773a2ede15ecd0c5;p=thirdparty%2Flibcgroup.git api.c: Fix strncpy() truncation warning Fix the following strncpy() string truncation warning: In function ‘strncpy’, inlined from ‘cgroup_parse_rules_file’ at api.c:814:3: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ output may be truncated copying 4095 bytes from a string of length 4095 [-Wstringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Tom Hromatka --- diff --git a/src/api.c b/src/api.c index 4e6e3b9e..51c4779e 100644 --- a/src/api.c +++ b/src/api.c @@ -813,6 +813,7 @@ static int cgroup_parse_rules_file(char *filename, bool cache, uid_t muid, } strncpy(newrule->destination, destination, sizeof(newrule->destination) - 1); + newrule->destination[sizeof(newrule->destination) - 1] = '\0'; if (has_options) { ret = cgroup_parse_rules_options(options, newrule);